572a785718
Before, this only waited for the download to complete. There was no guarantee that the layer had been registered in the graph and was ready use. This is especially problematic with v2 pulls, which wait for all downloads before extracting layers. Change Broadcaster to allow an error value to be propagated from Close to the waiters. Make the wait stop when the extraction is finished, rather than just the download. This also fixes v2 layer downloads to prefix the pool key with "layer:" instead of "img:". "img:" is the wrong prefix, because this is what v1 uses for entire images. A v1 pull waiting for one of these operations to finish would only wait for that particular layer, not all its dependencies. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com> |
||
---|---|---|
ansiescape | ||
archive | ||
broadcastwriter | ||
chrootarchive | ||
devicemapper | ||
directory | ||
fileutils | ||
graphdb | ||
homedir | ||
httputils | ||
integration | ||
ioutils | ||
jsonlog | ||
jsonmessage | ||
listenbuffer | ||
mflag | ||
mount | ||
namesgenerator | ||
nat | ||
parsers | ||
pidfile | ||
plugins | ||
pools | ||
progressreader | ||
promise | ||
proxy | ||
pubsub | ||
random | ||
reexec | ||
signal | ||
sockets | ||
stdcopy | ||
streamformatter | ||
stringid | ||
stringutils | ||
symlink | ||
sysinfo | ||
system | ||
tailfile | ||
tarsum | ||
term | ||
timeoutconn | ||
timeutils | ||
tlsconfig | ||
truncindex | ||
ulimit | ||
units | ||
urlutil | ||
useragent | ||
version | ||
README.md |
pkg/ is a collection of utility packages used by the Docker project without being specific to its internals.
Utility packages are kept separate from the docker core codebase to keep it as small and concise as possible. If some utilities grow larger and their APIs stabilize, they may be moved to their own repository under the Docker organization, to facilitate re-use by other projects. However that is not the priority.
The directory pkg
is named after the same directory in the camlistore project. Since Brad is a core
Go maintainer, we thought it made sense to copy his methods for organizing Go code :) Thanks Brad!
Because utility packages are small and neatly separated from the rest of the codebase, they are a good place to start for aspiring maintainers and contributors. Get in touch if you want to help maintain them!