almost all PR discussion fixes

static/directives/triggered-build-description.html

@@ -1,18 +1,17 @@
 <div class="triggered-build-description-element">
 
-<span class="tbd-content" class="manual" ng-if="!build.trigger && !build.job_config.manual_user">
-  (Manually Triggered Build)
-</span>
+  <span class="tbd-content" class="manual" ng-if="!build.trigger && !build.job_config.manual_user">
+    (Manually Triggered Build)
+  </span>
 
-<span class="tbd-content" ng-if="!build.trigger && build.job_config.manual_user">
-  <i class="fa fa-user"></i> {{ build.job_config.manual_user }}
-</span>
+  <span class="tbd-content" ng-if="!build.trigger && build.job_config.manual_user">
+    <i class="fa fa-user"></i> {{ build.job_config.manual_user }}
+  </span>
 
-<span ng-switch on="build.trigger.service" ng-if="build.trigger">
-  <!-- GitHub -->
-  <span ng-switch-when="github">
-    <!-- Full Commit Information -->
-    <span class="tbd-content" ng-if="build.job_config.trigger_metadata.commit_info">
+  <!-- Full Commit Information -->
+  <span class="tbd-content" ng-if="build.job_config.trigger_metadata.commit_info" ng-switch on="build.trigger.service">
+    <!-- GitHub -->
+    <div ng-switch-when="github">
       <div class="commit-message">
         <a ng-href="{{ getGitHubRepoURL(build) }}/commit/{{ build.job_config.trigger_metadata.commit_sha }}"
            target="_blank">
@@ -39,30 +38,10 @@
               branch-template="getGitHubRepoURL(build) + '/tree/{branch}'"
               tag-template="getGitHubRepoURL(build) + '/releases/tag/{tag}'"></span>
       </div>
-     </span>
+    </div>
 
-    <!-- Just commit SHA -->
-    <span class="tbd-content" ng-if="build.job_config.trigger_metadata && !build.job_config.trigger_metadata.commit_info">
-      Triggered by commit
-      <span class="source-commit-link"
-            commit-sha="build.job_config.trigger_metadata.commit_sha"
-            url-template="getGitHubRepoURL(build) + '/commit/{sha}'"></span>
-    </span>
-
-    <!-- No information -->
-    <span class="tbd-content" ng-if="!build.job_config.trigger_metadata">
-      Triggered by commit to
-      <i class="fa fa-github fa-lg" data-title="GitHub" data-container="body" bs-tooltip></i>
-      <a ng-href="{{ getGitHubRepoURL(build) }}" target="_new">
-        {{ build.trigger.config.build_source }}
-      </a>
-    </span>
-  </span>
-
-  <!-- Custom -->
-  <span ng-switch-when="custom">
-    <!-- Full Commit Information -->
-    <span ng-if="build.job_config.trigger_metadata.commit_info">
+    <!-- Git -->
+    <div ng-switch-when="custom-git">
       <div class="commit-message">
         {{ build.job_config.trigger_metadata.commit_info.message }}
       </div>
@@ -81,25 +60,41 @@
           {{ build.job_config.trigger_metadata.ref }}
         </span>
       </div>
-     </span>
+    </div>
+ </span>
 
-    <!-- Just commit SHA -->
-    <span ng-if="build.job_config.trigger_metadata && !build.job_config.trigger_metadata.commit_info">
-      Triggered by commit
-      <span>
-        {{ build.job_config.trigger_metadata.commit_sha }}
-      </span>
-    </span>
+  <!-- Just commit SHA -->
+  <span class="tbd-content" ng-if="build.job_config.trigger_metadata && !build.job_config.trigger_metadata.commit_info" ng-switch on="build.trigger.service">
+    Triggered by commit
+    <!-- GitHub -->
+    <div ng-switch-when="github">
+      <span class="source-commit-link"
+            commit-sha="build.job_config.trigger_metadata.commit_sha"
+            url-template="getGitHubRepoURL(build) + '/commit/{sha}'"></span>
+    </div>
 
-    <!-- No information -->
-    <span ng-if="!build.job_config.trigger_metadata">
-      Triggered by commit to
-      <i class="fa fa-git fa-lg" data-title="git" bs-tooltip="tooltip.title"></i>
-      {{ build.trigger.config.build_source }}
-    </span>
+    <!-- Git -->
+    <div ng-switch-when="custom-git">
+      <span>{{ build.job_config.trigger_metadata.commit_sha }}</span>
+    </div>
+  </span>
+
+  <!-- No information -->
+  <span class="tbd-content" ng-if="!build.job_config.trigger_metadata" ng-switch on="build.trigger.service">
+    Triggered by commit to
+    <!-- GitHub -->
+    <div ng-switch-when="github">
+      <i class="fa fa-github fa-lg" data-title="GitHub" data-container="body" bs-tooltip></i>
+      <a ng-href="{{ getGitHubRepoURL(build) }}" target="_new">
+        {{ build.trigger.config.build_source }}
+      </a>
+    </div>
+
+    <!-- Git -->
+    <div ng-switch-when="custom-git">
+      <i class="fa fa-git fa-lg" data-title="git" data-container="body" bs-tooltip></i>
+      {{ build.trigger.config.build_source }}
+    </div>
   </span>
 
-  <!-- Unknown -->
-  <span ng-switch-default>Unknown Build Trigger</span>
-</span>
 </div>