Phase 2 of migrating repo namespaces to referencing user objects, backfilling the rows without a value for namespace_user, and changing all accesses to go through the namespace_user object. All tests are passing, manual testing still required.

endpoints/api/build.py

@@ -169,7 +169,7 @@ class RepositoryBuildList(RepositoryParamResource):
     # was used.
     associated_repository = model.get_repository_for_resource(dockerfile_id)
     if associated_repository:
-      if not ModifyRepositoryPermission(associated_repository.namespace,
+      if not ModifyRepositoryPermission(associated_repository.namespace_user.username,
                                         associated_repository.name):
         raise Unauthorized()
 

endpoints/api/repoemail.py

@@ -20,7 +20,7 @@ def record_view(record):
   return {
     'email': record.email,
     'repository': record.repository.name,
-    'namespace': record.repository.namespace,
+    'namespace': record.repository.namespace_user.username,
     'confirmed': record.confirmed
   }
 

endpoints/api/repository.py

@@ -80,8 +80,7 @@ class RepositoryList(ApiResource):
 
       visibility = req['visibility']
 
-      repo = model.create_repository(namespace_name, repository_name, owner,
-                                     visibility)
+      repo = model.create_repository(namespace_name, repository_name, owner, visibility)
       repo.description = req['description']
       repo.save()
 
@@ -110,7 +109,7 @@ class RepositoryList(ApiResource):
     """Fetch the list of repositories under a variety of situations."""
     def repo_view(repo_obj):
       return {
-        'namespace': repo_obj.namespace,
+        'namespace': repo_obj.namespace_user.username,
         'name': repo_obj.name,
         'description': repo_obj.description,
         'is_public': repo_obj.visibility.name == 'public',
@@ -134,7 +133,8 @@ class RepositoryList(ApiResource):
 
     response['repositories'] = [repo_view(repo) for repo in repo_query
                                 if (repo.visibility.name == 'public' or
-                                    ReadRepositoryPermission(repo.namespace, repo.name).can())]
+                                    ReadRepositoryPermission(repo.namespace_user.username,
+                                                             repo.name).can())]
 
     return response
 

endpoints/api/search.py

@@ -111,7 +111,7 @@ class FindRepositories(ApiResource):
 
     def repo_view(repo):
       return {
-        'namespace': repo.namespace,
+        'namespace': repo.namespace_user.username,
         'name': repo.name,
         'description': repo.description
       }
@@ -125,5 +125,5 @@ class FindRepositories(ApiResource):
     return {
       'repositories': [repo_view(repo) for repo in matching
                        if (repo.visibility.name == 'public' or 
-                           ReadRepositoryPermission(repo.namespace, repo.name).can())]
+                           ReadRepositoryPermission(repo.namespace_user.username, repo.name).can())]
     }

endpoints/api/trigger.py

@@ -205,7 +205,7 @@ class BuildTriggerActivate(RepositoryParamResource):
                                           'write')
 
       try:
-        repository_path = '%s/%s' % (trigger.repository.namespace,
+        repository_path = '%s/%s' % (trigger.repository.namespace_user.username,
                                      trigger.repository.name)
         path = url_for('webhooks.build_trigger_webhook',
                        repository=repository_path, trigger_uuid=trigger.uuid)