- Fix initdb

- Add ability to specific custom fields for manual running of build triggers and add a "branch name" selector for running github builds

endpoints/trigger.py

@@ -36,6 +36,9 @@ class TriggerActivationException(Exception):
 class TriggerDeactivationException(Exception):
   pass
 
+class TriggerStartException(Exception):
+  pass
+
 class ValidationRequestException(Exception):
   pass
 
@@ -109,12 +112,19 @@ class BuildTrigger(object):
     """
     raise NotImplementedError
 
-  def manual_start(self, auth_token, config):
+  def manual_start(self, auth_token, config, run_parameters = None):
     """
     Manually creates a repository build for this trigger.
     """
     raise NotImplementedError
 
+  def list_field_values(self, auth_token, config, field_name):
+    """
+    Lists all values for the given custom trigger field. For example, a trigger might have a
+    field named "branches", and this method would return all branches.
+    """
+    raise NotImplementedError
+
   @classmethod
   def service_name(cls):
     """
@@ -345,14 +355,37 @@ class GithubBuildTrigger(BuildTrigger):
     return GithubBuildTrigger._prepare_build(config, repo, commit_sha,
                                              short_sha, ref)
 
-  def manual_start(self, auth_token, config):
-    source = config['build_source']
+  def manual_start(self, auth_token, config, run_parameters = None):
+    try:
+      source = config['build_source']
+      run_parameters = run_parameters or {}
 
-    gh_client = self._get_client(auth_token)
-    repo = gh_client.get_repo(source)
-    master = repo.get_branch(repo.default_branch)
-    master_sha = master.commit.sha
-    short_sha = GithubBuildTrigger.get_display_name(master_sha)
-    ref = 'refs/heads/%s' % repo.default_branch
+      gh_client = self._get_client(auth_token)
+      repo = gh_client.get_repo(source)
+      master = repo.get_branch(repo.default_branch)
+      master_sha = master.commit.sha
+      short_sha = GithubBuildTrigger.get_display_name(master_sha)
+      ref = 'refs/heads/%s' % (run_parameters.get('branch_name') or repo.default_branch)
 
-    return self._prepare_build(config, repo, master_sha, short_sha, ref)
+      return self._prepare_build(config, repo, master_sha, short_sha, ref)
+    except GithubException as ghe:
+      raise TriggerStartException(ghe.data['message'])
+
+
+  def list_field_values(self, auth_token, config, field_name):
+    if field_name == 'branch_name':
+      gh_client = self._get_client(auth_token)
+      source = config['build_source']
+      repo = gh_client.get_repo(source)
+      branches = [branch['name'] for branch in repo.get_branches()]
+
+      if not repo.default_branch in branches:
+        branches.insert(0, repo.default_branch)
+
+      if branches[0] != repo.default_branch:
+        branches.remove(repo.default_branch)
+        branches.insert(0, repo.default_branch)
+
+      return branches
+
+    return None