vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Small optimization in manifest loading in the OCI data model

Browse source
This commit is contained in:
Joseph Schorr 2019-01-29 13:11:48 -05:00
parent 6c3eab47e0
commit 0d1ac7a4bb
3 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
data/registry_model/interface.py
View file

@ -42,7 +42,7 @@ class RegistryDataInterface(object):
or None if none. """ or None if none. """
@abstractmethod @abstractmethod
def get_manifest_for_tag(self, tag, backfill_if_necessary=False): def get_manifest_for_tag(self, tag, backfill_if_necessary=False, include_legacy_image=False):
""" Returns the manifest associated with the given tag. """ """ Returns the manifest associated with the given tag. """
@abstractmethod @abstractmethod

5
data/registry_model/registry_oci_model.py
View file

@ -114,9 +114,12 @@ class OCIModel(SharedModel, RegistryDataInterface):
assert found_tag is None or not found_tag.hidden assert found_tag is None or not found_tag.hidden
return Tag.for_tag(found_tag) return Tag.for_tag(found_tag)
def get_manifest_for_tag(self, tag, backfill_if_necessary=False): def get_manifest_for_tag(self, tag, backfill_if_necessary=False, include_legacy_image=False):
""" Returns the manifest associated with the given tag. """ """ Returns the manifest associated with the given tag. """
legacy_image = None
if include_legacy_image:
legacy_image = oci.shared.get_legacy_image_for_manifest(tag._manifest) legacy_image = oci.shared.get_legacy_image_for_manifest(tag._manifest)
return Manifest.for_manifest(tag._manifest, LegacyImage.for_image(legacy_image)) return Manifest.for_manifest(tag._manifest, LegacyImage.for_image(legacy_image))
def lookup_manifest_by_digest(self, repository_ref, manifest_digest, allow_dead=False, def lookup_manifest_by_digest(self, repository_ref, manifest_digest, allow_dead=False,

2
data/registry_model/registry_pre_oci_model.py
View file

@ -66,7 +66,7 @@ class PreOCIModel(SharedModel, RegistryDataInterface):
assert found_tag is None or not found_tag.hidden assert found_tag is None or not found_tag.hidden
return Tag.for_repository_tag(found_tag) return Tag.for_repository_tag(found_tag)
def get_manifest_for_tag(self, tag, backfill_if_necessary=False): def get_manifest_for_tag(self, tag, backfill_if_necessary=False, include_legacy_image=False):
""" Returns the manifest associated with the given tag. """ """ Returns the manifest associated with the given tag. """
try: try:
tag_manifest = database.TagManifest.get(tag_id=tag._db_id) tag_manifest = database.TagManifest.get(tag_id=tag._db_id)