From 0e2bff972fd4ab308235502204cf1372e6e91cb6 Mon Sep 17 00:00:00 2001
From: Joseph Schorr <joseph.schorr@coreos.com>
Date: Fri, 1 Jun 2018 17:07:23 -0400
Subject: [PATCH] Convert storage replication tests to pytest format

---
 test/test_storagereplication.py | 119 ++++++++++++++++----------------
 1 file changed, 61 insertions(+), 58 deletions(-)

diff --git a/test/test_storagereplication.py b/test/test_storagereplication.py
index fd3b679e8..c5c6c3ad9 100644
--- a/test/test_storagereplication.py
+++ b/test/test_storagereplication.py
@@ -1,66 +1,69 @@
-import unittest
 import hashlib
 
+import pytest
+
 from app import storage
-from initdb import setup_database_for_testing, finished_database_for_testing
 from data import model, database
-from workers.storagereplication import StorageReplicationWorker
 from storage.basestorage import StoragePaths
+from workers.storagereplication import StorageReplicationWorker
 
-class TestStorageReplication(unittest.TestCase):
-  def setUp(self):
-    setup_database_for_testing(self)
-
-    self.worker = StorageReplicationWorker(None)
-    self.paths = StoragePaths()
-
-    # Add both regions for a user.
-    self.user = model.user.get_user('devtable')
-    database.UserRegion.create(user=self.user,
-                               location=database.ImageStorageLocation.get(name='local_us'))
-    database.UserRegion.create(user=self.user,
-                               location=database.ImageStorageLocation.get(name='local_eu'))
-
-  def tearDown(self):
-    finished_database_for_testing(self)
-
-  def test_storage_replication_v1(self):
-    # Add a storage entry with a V1 path.
-    v1_storage = model.storage.create_v1_storage('local_us')
-    content_path = self.paths.v1_image_layer_path(v1_storage.uuid)
-    storage.put_content(['local_us'], content_path, 'some content')
-
-    # Call replicate on it and verify it replicates.
-    result = self.worker.replicate_storage(self.user, v1_storage.uuid)
-    self.assertTrue(result)
-
-    # Ensure that the data was replicated to the other "region".
-    self.assertEquals('some content', storage.get_content(['local_eu'], content_path))
-
-    locations = model.storage.get_storage_locations(v1_storage.uuid)
-    self.assertEquals(2, len(locations))
-
-  def test_storage_replication_cas(self):
-    # Add a storage entry with a CAS path.
-    content_checksum = 'sha256:' + hashlib.sha256('some content').hexdigest()
-    cas_storage = database.ImageStorage.create(cas_path=True, content_checksum=content_checksum)
-
-    location = database.ImageStorageLocation.get(name='local_us')
-    database.ImageStoragePlacement.create(storage=cas_storage, location=location)
-
-    content_path = self.paths.blob_path(cas_storage.content_checksum)
-    storage.put_content(['local_us'], content_path, 'some content')
-
-    # Call replicate on it and verify it replicates.
-    result = self.worker.replicate_storage(self.user, cas_storage.uuid)
-    self.assertTrue(result)
-
-    # Ensure that the data was replicated to the other "region".
-    self.assertEquals('some content', storage.get_content(['local_eu'], content_path))
-
-    locations = model.storage.get_storage_locations(cas_storage.uuid)
-    self.assertEquals(2, len(locations))
+from test.fixtures import *
 
 
-if __name__ == '__main__':
-  unittest.main()
+@pytest.fixture()
+def storage_user(app):
+  user = model.user.get_user('devtable')
+  database.UserRegion.create(user=user,
+                             location=database.ImageStorageLocation.get(name='local_us'))
+  database.UserRegion.create(user=user,
+                             location=database.ImageStorageLocation.get(name='local_eu'))
+  return user
+
+
+@pytest.fixture()
+def storage_paths():
+  return StoragePaths()
+
+
+@pytest.fixture()
+def replication_worker():
+  return StorageReplicationWorker(None)
+
+
+def test_storage_replication_v1(storage_user, storage_paths, replication_worker, app):
+  # Add a storage entry with a V1 path.
+  v1_storage = model.storage.create_v1_storage('local_us')
+  content_path = storage_paths.v1_image_layer_path(v1_storage.uuid)
+  storage.put_content(['local_us'], content_path, 'some content')
+
+  # Call replicate on it and verify it replicates.
+  result = replication_worker.replicate_storage(storage_user, v1_storage.uuid)
+  assert result
+
+  # Ensure that the data was replicated to the other "region".
+  assert storage.get_content(['local_eu'], content_path) == 'some content'
+
+  locations = model.storage.get_storage_locations(v1_storage.uuid)
+  assert len(locations) == 2
+
+
+def test_storage_replication_cas(storage_user, storage_paths, replication_worker, app):
+  # Add a storage entry with a CAS path.
+  content_checksum = 'sha256:' + hashlib.sha256('some content').hexdigest()
+  cas_storage = database.ImageStorage.create(cas_path=True, content_checksum=content_checksum)
+
+  location = database.ImageStorageLocation.get(name='local_us')
+  database.ImageStoragePlacement.create(storage=cas_storage, location=location)
+
+  content_path = storage_paths.blob_path(cas_storage.content_checksum)
+  storage.put_content(['local_us'], content_path, 'some content')
+
+  # Call replicate on it and verify it replicates.
+  result = replication_worker.replicate_storage(storage_user, cas_storage.uuid)
+  assert result
+
+  # Ensure that the data was replicated to the other "region".
+  assert storage.get_content(['local_eu'], content_path) == 'some content'
+
+  locations = model.storage.get_storage_locations(cas_storage.uuid)
+  assert len(locations) == 2