Unify the logging infrastructure and turn the prod logging level to INFO in preparation for picking up a new cloud logger.

endpoints/index.py

@@ -23,7 +23,6 @@ from endpoints.notificationhelper import spawn_notification
 import features
 
 logger = logging.getLogger(__name__)
-profile = logging.getLogger('application.profiler')
 
 index = Blueprint('index', __name__)
 
@@ -120,7 +119,7 @@ def create_user():
 
   else:
     # New user case
-    profile.debug('Creating user')
+    logger.debug('Creating user')
     new_user = None
 
     try:
@@ -128,10 +127,10 @@ def create_user():
     except model.TooManyUsersException as ex:
       abort(402, 'Seat limit has been reached for this license', issue='seat-limit')
 
-    profile.debug('Creating email code for user')
+    logger.debug('Creating email code for user')
     code = model.create_confirm_email_code(new_user)
 
-    profile.debug('Sending email code to user')
+    logger.debug('Sending email code to user')
     send_confirmation_email(new_user.username, new_user.email, code.code)
 
     return make_response('Created', 201)
@@ -168,12 +167,12 @@ def update_user(username):
     update_request = request.get_json()
 
     if 'password' in update_request:
-      profile.debug('Updating user password')
+      logger.debug('Updating user password')
       model.change_password(get_authenticated_user(),
                             update_request['password'])
 
     if 'email' in update_request:
-      profile.debug('Updating user email')
+      logger.debug('Updating user email')
       model.update_email(get_authenticated_user(), update_request['email'])
 
     return jsonify({
@@ -189,13 +188,13 @@ def update_user(username):
 @parse_repository_name
 @generate_headers(role='write')
 def create_repository(namespace, repository):
-  profile.debug('Parsing image descriptions')
+  logger.debug('Parsing image descriptions')
   image_descriptions = json.loads(request.data.decode('utf8'))
 
-  profile.debug('Looking up repository')
+  logger.debug('Looking up repository')
   repo = model.get_repository(namespace, repository)
 
-  profile.debug('Repository looked up')
+  logger.debug('Repository looked up')
   if not repo and get_authenticated_user() is None:
     logger.debug('Attempt to create new repository without user auth.')
     abort(401,
@@ -219,11 +218,11 @@ def create_repository(namespace, repository):
             issue='no-create-permission',
             namespace=namespace)
 
-    profile.debug('Creaing repository with owner: %s', get_authenticated_user().username)
+    logger.debug('Creaing repository with owner: %s', get_authenticated_user().username)
     repo = model.create_repository(namespace, repository,
                                    get_authenticated_user())
 
-  profile.debug('Determining already added images')
+  logger.debug('Determining already added images')
   added_images = OrderedDict([(desc['id'], desc) for desc in image_descriptions])
   new_repo_images = dict(added_images)
 
@@ -239,7 +238,7 @@ def create_repository(namespace, repository):
     for existing in existing_images:
       added_images.pop(existing.docker_image_id)
 
-  profile.debug('Creating/Linking necessary images')
+  logger.debug('Creating/Linking necessary images')
   username = get_authenticated_user() and get_authenticated_user().username
   translations = {}
   for image_description in added_images.values():
@@ -247,7 +246,7 @@ def create_repository(namespace, repository):
                                     translations, storage.preferred_locations[0])
 
 
-  profile.debug('Created images')
+  logger.debug('Created images')
   track_and_log('push_repo', repo)
   return make_response('Created', 201)
 
@@ -260,14 +259,14 @@ def update_images(namespace, repository):
   permission = ModifyRepositoryPermission(namespace, repository)
 
   if permission.can():
-    profile.debug('Looking up repository')
+    logger.debug('Looking up repository')
     repo = model.get_repository(namespace, repository)
     if not repo:
       # Make sure the repo actually exists.
       abort(404, message='Unknown repository', issue='unknown-repo')
 
     if get_authenticated_user():
-      profile.debug('Publishing push event')
+      logger.debug('Publishing push event')
       username = get_authenticated_user().username
 
       # Mark that the user has pushed the repo.
@@ -280,11 +279,11 @@ def update_images(namespace, repository):
       event = userevents.get_event(username)
       event.publish_event_data('docker-cli', user_data)
 
-    profile.debug('GCing repository')
+    logger.debug('GCing repository')
     num_removed = model.garbage_collect_repository(namespace, repository)
 
     # Generate a job for each notification that has been added to this repo
-    profile.debug('Adding notifications for repository')
+    logger.debug('Adding notifications for repository')
 
     updated_tags = session.get('pushed_tags', {})
     event_data = {
@@ -307,13 +306,13 @@ def get_repository_images(namespace, repository):
   # TODO invalidate token?
   if permission.can() or model.repository_is_public(namespace, repository):
     # We can't rely on permissions to tell us if a repo exists anymore
-    profile.debug('Looking up repository')
+    logger.debug('Looking up repository')
     repo = model.get_repository(namespace, repository)
     if not repo:
       abort(404, message='Unknown repository', issue='unknown-repo')
 
     all_images = []
-    profile.debug('Retrieving repository images')
+    logger.debug('Retrieving repository images')
     for image in model.get_repository_images(namespace, repository):
       new_image_view = {
         'id': image.docker_image_id,
@@ -321,7 +320,7 @@ def get_repository_images(namespace, repository):
       }
       all_images.append(new_image_view)
 
-    profile.debug('Building repository image response')
+    logger.debug('Building repository image response')
     resp = make_response(json.dumps(all_images), 200)
     resp.mimetype = 'application/json'