vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix timeline's delete-then-tag display bug

Browse source 
Currently, if a tag is deleted and then assigned later, it shows up as a move, rather than a delete+create. This is due to the threshold check being backwards.

Fixes #1824
This commit is contained in:
Joseph Schorr 2016-09-12 15:46:23 -04:00
parent c027e6cc27
commit 13bcba4206
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
static/js/directives/ui/repo-tag-history.js
View file

@ -75,7 +75,8 @@ angular.module('quay').directive('repoTagHistory', function () {
// then the action was a move, rather than a delete and a create.
var currentEntries = tagEntries[tagName];
var futureEntry = currentEntries.length > 0 ? currentEntries[currentEntries.length - 1] : {};
if (tag.end_ts - futureEntry.start_ts <= MOVE_THRESHOLD) {
if (futureEntry.start_ts - tag.end_ts <= MOVE_THRESHOLD) {
removeEntry(futureEntry);
addEntry(futureEntry.reversion ? 'revert': 'move', tag.end_ts,
futureEntry.docker_image_id, dockerImageId);