Some fixes for code review.
This commit is contained in:
parent
f15b3d5b84
commit
14eb3005b6
4 changed files with 26 additions and 27 deletions
|
@ -820,9 +820,10 @@ class SuperUserServiceKeyApproval(ApiResource):
|
|||
|
||||
abort(403)
|
||||
|
||||
|
||||
@resource('/v1/messages')
|
||||
@show_if(features.SUPER_USERS)
|
||||
class Messages(ApiResource):
|
||||
class SuperUserMessages(ApiResource):
|
||||
""" Resource for getting a list of super user messages """
|
||||
|
||||
schemas = {
|
||||
|
@ -831,21 +832,17 @@ class Messages(ApiResource):
|
|||
'type': 'object',
|
||||
'description': 'Messages that a super user has saved in the past',
|
||||
'properties': {
|
||||
'messages': {
|
||||
'type': 'array',
|
||||
'description': 'Array of message',
|
||||
'items': {
|
||||
'type': 'object',
|
||||
'description': 'A single message',
|
||||
'properties': {
|
||||
'id':{
|
||||
'type': 'integer',
|
||||
'description': 'The message id',
|
||||
},
|
||||
'content': {
|
||||
'type': 'string',
|
||||
'description': 'The actual message',
|
||||
},
|
||||
'message': {
|
||||
'type': 'object',
|
||||
'description': 'A single message',
|
||||
'properties': {
|
||||
'id': {
|
||||
'type': 'integer',
|
||||
'description': 'The message id',
|
||||
},
|
||||
'content': {
|
||||
'type': 'string',
|
||||
'description': 'The actual message',
|
||||
},
|
||||
}
|
||||
},
|
||||
|
@ -856,9 +853,9 @@ class Messages(ApiResource):
|
|||
@nickname('getMessages')
|
||||
def get(self):
|
||||
""" Return a super users messages """
|
||||
messages = model.message.get_messages()
|
||||
messages = list(model.message.get_messages())
|
||||
return {
|
||||
'messages': messages,
|
||||
'messages': [message_view(m) for m in messages],
|
||||
}
|
||||
|
||||
@require_scope(scopes.SUPERUSER)
|
||||
|
@ -867,4 +864,7 @@ class Messages(ApiResource):
|
|||
def post(self):
|
||||
""" Create a message """
|
||||
body = request.get_json()
|
||||
model.message.create(body['messages'])
|
||||
model.message.create([body['message']])
|
||||
|
||||
def message_view(message):
|
||||
return {'id': message.id, 'content': message.content}
|
||||
|
|
Reference in a new issue