- Turn on foreign key constraint checking in the tests

- Change all ForeignKeyField's that refer to users to use our custom class, and mark those that allow robots
- Change robot delete to only execute the subset of queries necessary to actually delete robots

test/test_api_usage.py

@@ -1780,7 +1780,7 @@ class TestOrgSubscription(ApiTestCase):
 
 class TestUserRobots(ApiTestCase):
   def getRobotNames(self):
-    return [r['name'] for r in self.getJsonResponse(UserRobotList)['robots']]
+    return [r['name'] for r in self.getJsonResponse(UserRobotList)['robots']]    
 
   def test_robots(self):
     self.login(NO_ACCESS_USER)
@@ -1834,6 +1834,65 @@ class TestOrgRobots(ApiTestCase):
     return [r['name'] for r in self.getJsonResponse(OrgRobotList,
                                                     params=dict(orgname=ORGANIZATION))['robots']]
 
+  def test_delete_robot_after_use(self):
+    self.login(ADMIN_ACCESS_USER)
+
+    # Create the robot.
+    self.putJsonResponse(OrgRobot,
+                        params=dict(orgname=ORGANIZATION, robot_shortname='bender'),
+                        expected_code=201)
+
+    # Add the robot to a team.
+    membername = ORGANIZATION + '+bender'
+    self.putJsonResponse(TeamMember,
+                         params=dict(orgname=ORGANIZATION, teamname='readers',
+                                     membername=membername))
+
+    # Add a repository permission.
+    self.putJsonResponse(RepositoryUserPermission,
+                         params=dict(repository=ORGANIZATION + '/' + ORG_REPO, username=membername),
+                         data=dict(role='read'))
+
+    # Add a permission prototype with the robot as the activating user.
+    self.postJsonResponse(PermissionPrototypeList,
+                           params=dict(orgname=ORGANIZATION),
+                           data=dict(role='read',
+                                     activating_user={'name': membername},
+                                     delegate={'kind': 'user',
+                                               'name': membername}))
+
+    # Add a permission prototype with the robot as the delegating user.
+    self.postJsonResponse(PermissionPrototypeList,
+                           params=dict(orgname=ORGANIZATION),
+                           data=dict(role='read',
+                                     delegate={'kind': 'user',
+                                               'name': membername}))
+
+    # Add a build trigger with the robot as the pull robot.
+    database.BuildTriggerService.create(name='fakeservice')
+
+    # Add a new fake trigger.
+    repo = model.get_repository(ORGANIZATION, ORG_REPO)
+    user = model.get_user(ADMIN_ACCESS_USER)
+    pull_robot = model.get_user(membername)
+    model.create_build_trigger(repo, 'fakeservice', 'sometoken', user, pull_robot=pull_robot)
+
+    # Delete the robot and verify it works.
+    self.deleteResponse(OrgRobot,
+                        params=dict(orgname=ORGANIZATION, robot_shortname='bender'))
+
+    # All the above records should now be deleted, along with the robot. We verify a few of the
+    # critical ones below.
+
+    # Check the team.
+    team = model.get_organization_team(ORGANIZATION, 'readers')
+    members =  [member.username for member in model.get_organization_team_members(team.id)]
+    self.assertFalse(membername in members)    
+
+    # Check the robot itself.
+    self.assertIsNone(model.get_user(membername))
+
+
   def test_robots(self):
     self.login(ADMIN_ACCESS_USER)