vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Make build package UI a bit nicer and make sure it always executes via a scope apply

Browse source
This commit is contained in:
Joseph Schorr 2014-07-14 16:33:00 -04:00
parent abe2ffb377
commit 18ec8c0f93
2 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
static/js/controllers.js
View file

@ -921,7 +921,11 @@ function BuildPackageCtrl($scope, Restangular, ApiService, DataFileService, $rou
}); });
}; };
DataFileService.readDataArrayAsPossibleArchive(uint8array, archiveread, notarchive); setTimeout(function() {
$scope.$apply(function() {
DataFileService.readDataArrayAsPossibleArchive(uint8array, archiveread, notarchive);
});
}, 0);
}; };
var downloadBuildPack = function(url) { var downloadBuildPack = function(url) {

9
static/partials/build-package.html
View file

@ -23,6 +23,11 @@
Error: Could not download the build pack Error: Could not download the build pack
</div> </div>
<div class="row" ng-show="!downloading && !downloadError && !loaded">
Reading... <span class="quay-spinner"></span>
</div>
<div class="row" ng-show="loaded"> <div class="row" ng-show="loaded">
<ul class="nav nav-tabs"> <ul class="nav nav-tabs">
<li class="active"><a href="javascript:void(0)" data-toggle="tab" data-target="#dockerfile">Dockerfile</a></li> <li class="active"><a href="javascript:void(0)" data-toggle="tab" data-target="#dockerfile">Dockerfile</a></li>
@ -34,7 +39,9 @@
<div class="tab-pane active" id="dockerfile"> <div class="tab-pane active" id="dockerfile">
<div class="dockerfile-path" ng-if="dockerFileContents">{{ dockerFilePath }}</div> <div class="dockerfile-path" ng-if="dockerFileContents">{{ dockerFilePath }}</div>
<div class="dockerfile-view" contents="dockerFileContents" ng-if="dockerFileContents"></div> <div class="dockerfile-view" contents="dockerFileContents" ng-if="dockerFileContents"></div>
<span ng-if="!dockerFileContents">No Dockerfile found in the build pack</span> <div ng-if="!dockerFileContents" style="padding: 10px; margin-top: 20px;">
No Dockerfile found in the build pack
</div>
</div> </div>
<!-- File tree --> <!-- File tree -->