Lay foundation for truly dynamic external logins

Moves all the external login services into a set of classes that share as much code as possible. These services are then registered on both the client and server, allowing us in the followup change to dynamically register new handlers

static/js/directives/ui/external-login-button.js

@@ -12,12 +12,11 @@ angular.module('quay').directive('externalLoginButton', function () {
       'signInStarted': '&signInStarted',
       'redirectUrl': '=redirectUrl',
       'isLink': '=isLink',
-      'provider': '@provider',
+      'provider': '=provider',
       'action': '@action'
     },
     controller: function($scope, $timeout, $interval, ApiService, KeyService, CookieService, ExternalLoginService) {
       $scope.signingIn = false;
-      $scope.providerInfo = ExternalLoginService.getProvider($scope.provider);
 
       $scope.startSignin = function() {
         $scope.signInStarted({'service': $scope.provider});

static/js/directives/ui/external-logins-manager.js

@@ -34,11 +34,11 @@ angular.module('quay').directive('externalLoginsManager', function () {
         }
       });
 
-      $scope.detachExternalLogin = function(kind) {
+      $scope.detachExternalLogin = function(service_id) {
         if (!Features.DIRECT_LOGIN) { return; }
 
         var params = {
-          'servicename': kind
+          'service_id': service_id
         };
 
         ApiService.detachExternalLogin(null, params).then(function() {

static/js/directives/ui/icon-image-view.js

@@ -0,0 +1,18 @@
+/**
+ * An element which displays either an icon or an image, depending on the value.
+ */
+angular.module('quay').directive('iconImageView', function () {
+  var directiveDefinitionObject = {
+    priority: 0,
+    templateUrl: '/static/directives/icon-image-view.html',
+    replace: false,
+    transclude: true,
+    restrict: 'C',
+    scope: {
+      'value': '@value'
+    },
+    controller: function($scope, $element) {
+    }
+  };
+  return directiveDefinitionObject;
+});