Lay foundation for truly dynamic external logins

Moves all the external login services into a set of classes that share as much code as possible. These services are then registered on both the client and server, allowing us in the followup change to dynamically register new handlers

test/test_api_security.py

@@ -507,7 +507,7 @@ class TestSignin(ApiTestCase):
 class TestDetachExternal(ApiTestCase):
   def setUp(self):
     ApiTestCase.setUp(self)
-    self._set_url(DetachExternal, servicename='someservice')
+    self._set_url(DetachExternal, service_id='someservice')
 
   def test_post_anonymous(self):
     self._run_test('POST', 401, None, {})

test/test_endpoints.py

@@ -16,7 +16,7 @@ from Crypto.PublicKey import RSA
 from flask import url_for
 from jwkest.jwk import RSAKey
 
-from app import app
+from app import app, oauth_login
 from data import model
 from data.database import ServiceKeyApprovalType
 from endpoints import keyserver
@@ -30,7 +30,7 @@ from initdb import setup_database_for_testing, finished_database_for_testing
 from test.helpers import assert_action_logged
 
 try:
-  app.register_blueprint(oauthlogin_bp, url_prefix='/oauth')
+  app.register_blueprint(oauthlogin_bp, url_prefix='/oauth2')
 except ValueError:
   # This blueprint was already registered
   pass

test/testconfig.py

@@ -76,6 +76,9 @@ class TestConfig(DefaultConfig):
 
   PROMETHEUS_AGGREGATOR_URL = None
 
+  GITHUB_LOGIN_CONFIG = {}
+  GOOGLE_LOGIN_CONFIG = {}
+
   FEATURE_GITHUB_LOGIN = True
   FEATURE_GOOGLE_LOGIN = True
   FEATURE_DEX_LOGIN = True