Add tests for providers and update install script

util/config/provider/baseprovider.py

@@ -110,7 +110,7 @@ class BaseProvider(object):
     """
     raise NotImplementedError
   
-  def get_volume_path(self, directory, file):
+  def get_volume_path(self, directory, filename):
     """ Helper for constructing file paths, which may differ between providers. For example,
     kubernetes can't have subfolders in configmaps """
     raise NotImplementedError

util/config/provider/fileprovider.py

@@ -111,5 +111,5 @@ class FileConfigProvider(BaseProvider):
 
     return False
   
-  def get_volume_path(self, directory, file):
-    return os.path.join(directory, file)
+  def get_volume_path(self, directory, filename):
+    return os.path.join(directory, filename)

util/config/provider/k8sprovider.py

@@ -144,5 +144,5 @@ class KubernetesConfigProvider(FileConfigProvider):
     request = Request(method, url, data=data, headers=headers)
     return session.send(request.prepare(), verify=False, timeout=2)
 
-  def get_volume_path(self, directory, file):
-    return "_".join([directory, file])
+  def get_volume_path(self, directory, filename):
+    return "_".join([directory.rstrip('/'), filename])

util/config/provider/test/test_fileprovider.py

@@ -0,0 +1,29 @@
+import pytest
+
+from util.config.provider import FileConfigProvider 
+
+from test.fixtures import *
+
+
+class TestFileConfigProvider(FileConfigProvider):
+  def __init__(self):
+    self.yaml_filename = 'yaml_filename'
+    self._service_token = 'service_token'
+    self.config_volume = 'config_volume' 
+    self.py_filename = 'py_filename'
+    self.yaml_path = os.path.join(self.config_volume, self.yaml_filename)
+    self.py_path = os.path.join(self.config_volume, self.py_filename)
+
+
+@pytest.mark.parametrize('directory,filename,expected', [
+  ("directory", "file", "directory/file"),
+  ("directory/dir", "file", "directory/dir/file"),
+  ("directory/dir/", "file", "directory/dir/file"),
+  ("directory", "file/test", "directory/file/test"),
+])
+def test_get_volume_path(directory, filename, expected):
+  provider = TestFileConfigProvider()
+
+  assert expected == provider.get_volume_path(directory, filename)
+
+

util/config/provider/test/test_k8sprovider.py

@@ -0,0 +1,25 @@
+import pytest
+
+from util.config.provider import KubernetesConfigProvider
+
+from test.fixtures import *
+
+
+class TestKubernetesConfigProvider(KubernetesConfigProvider):
+  def __init__(self):
+    self.yaml_filename = 'yaml_filename'
+    self._service_token = 'service_token'
+
+
+@pytest.mark.parametrize('directory,filename,expected', [
+  ("directory", "file", "directory_file"),
+  ("directory/dir", "file", "directory/dir_file"),
+  ("directory/dir/", "file", "directory/dir_file"),
+  ("directory", "file/test", "directory_file/test"),
+])
+def test_get_volume_path(directory, filename, expected):
+  provider = TestKubernetesConfigProvider()
+  
+  assert expected == provider.get_volume_path(directory, filename)
+
+

util/config/provider/testprovider.py

@@ -90,6 +90,6 @@ class TestConfigProvider(BaseProvider):
     self._config['SUPER_USERS'] = ['devtable']
     self.files = {}
     
-  def get_volume_path(self, directory, file):
-    return os.path.join(directory, file)
+  def get_volume_path(self, directory, filename):
+    return os.path.join(directory, filename)