Make the app config more powerful in terms of injecting fake dependencies. Refactor the tests to use metaclasses and to actually all run.

config.py

@@ -2,6 +2,13 @@ import logging
 import sys
 
 from peewee import MySQLDatabase, SqliteDatabase
+from storage.s3 import S3Storage
+from storage.local import LocalStorage
+from data.userfiles import UserRequestFiles
+from util import analytics
+
+from test.teststorage import FakeStorage, FakeUserfiles
+from test import analytics as fake_analytics
 
 
 LOG_FORMAT = '%(asctime)-15s - %(levelname)s - %(pathname)s - ' + \
@@ -31,6 +38,12 @@ class SQLiteDB(object):
   DB_DRIVER = SqliteDatabase
 
 
+class EphemeralDB(object):
+  DB_NAME = ':memory:'
+  DB_CONNECTION_ARGS = {}
+  DB_DRIVER = SqliteDatabase
+
+
 class RDSMySQL(object):
   DB_NAME = 'quay'
   DB_CONNECTION_ARGS = {
@@ -49,12 +62,27 @@ class AWSCredentials(object):
 
 
 class S3Storage(AWSCredentials):
-  STORAGE_KIND = 's3'
+  STORAGE = S3Storage('', AWSCredentials.AWS_ACCESS_KEY,
+                      AWSCredentials.AWS_SECRET_KEY,
+                      AWSCredentials.REGISTRY_S3_BUCKET)
 
 
 class LocalStorage(object):
-  STORAGE_KIND = 'local'
-  LOCAL_STORAGE_DIR = 'test/data/registry'
+  STORAGE = LocalStorage('test/data/registry')
+
+
+class FakeStorage(object):
+  STORAGE = FakeStorage()
+
+
+class FakeUserfiles(object):
+  USERFILES = FakeUserfiles()
+
+
+class S3Userfiles(AWSCredentials):
+  USERFILES = UserRequestFiles(AWSCredentials.AWS_ACCESS_KEY,
+                               AWSCredentials.AWS_SECRET_KEY,
+                               AWSCredentials.REGISTRY_S3_BUCKET)
 
 
 class StripeTestConfig(object):
@@ -67,11 +95,16 @@ class StripeLiveConfig(object):
   STRIPE_PUBLISHABLE_KEY = 'pk_live_P5wLU0vGdHnZGyKnXlFG4oiu'
 
 
+class FakeAnalytics(object):
+  ANALYTICS = fake_analytics
+
+
 class MixpanelTestConfig(object):
+  ANALYTICS = analytics
   MIXPANEL_KEY = '38014a0f27e7bdc3ff8cc7cc29c869f9'
 
 
-class MixpanelProdConfig(object):
+class MixpanelProdConfig(MixpanelTestConfig):
   MIXPANEL_KEY = '50ff2b2569faa3a51c8f5724922ffb7e'
 
 
@@ -100,9 +133,18 @@ class BuildNodeConfig(object):
   BUILD_NODE_PULL_TOKEN = 'F02O2E86CQLKZUQ0O81J8XDHQ6F0N1V36L9JTOEEK6GKKMT1GI8PTJQT4OU88Y6G'
 
 
+class TestConfig(FlaskConfig, FakeStorage, EphemeralDB, FakeUserfiles,
+                 FakeAnalytics):
+  LOGGING_CONFIG = {
+    'level': logging.DEBUG,
+    'format': LOG_FORMAT
+  }
+  POPULATE_DB_TEST_DATA = True
+
+
 class DebugConfig(FlaskConfig, MailConfig, LocalStorage, SQLiteDB,
                   StripeTestConfig, MixpanelTestConfig, GitHubTestConfig,
-                  DigitalOceanConfig, AWSCredentials, BuildNodeConfig):
+                  DigitalOceanConfig, BuildNodeConfig, S3Userfiles):
   LOGGING_CONFIG = {
     'level': logging.DEBUG,
     'format': LOG_FORMAT
@@ -115,7 +157,7 @@ class DebugConfig(FlaskConfig, MailConfig, LocalStorage, SQLiteDB,
 class LocalHostedConfig(FlaskConfig, MailConfig, S3Storage, RDSMySQL,
                         StripeLiveConfig, MixpanelTestConfig,
                         GitHubProdConfig, DigitalOceanConfig,
-                        BuildNodeConfig):
+                        BuildNodeConfig, S3Userfiles):
   LOGGING_CONFIG = {
     'level': logging.DEBUG,
     'format': LOG_FORMAT
@@ -125,7 +167,8 @@ class LocalHostedConfig(FlaskConfig, MailConfig, S3Storage, RDSMySQL,
 
 class ProductionConfig(FlaskConfig, MailConfig, S3Storage, RDSMySQL,
                        StripeLiveConfig, MixpanelProdConfig,
-                       GitHubProdConfig, DigitalOceanConfig, BuildNodeConfig):
+                       GitHubProdConfig, DigitalOceanConfig, BuildNodeConfig,
+                       S3Userfiles):
   LOGGING_CONFIG = {
     'stream': sys.stderr,
     'level': logging.DEBUG,