vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Make build system resistant to Redis being broken

Browse source 
Fixes #549
This commit is contained in:
Joseph Schorr 2015-09-30 15:15:10 -04:00
parent 1b7449188b
commit 2d3092b826
1 changed files with 14 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

16
buildman/jobutil/buildstatus.py
View file

@ -1,6 +1,11 @@
from data.database import BUILD_PHASE from data.database import BUILD_PHASE
from data import model from data import model
from redis import RedisError
import datetime import datetime
import logging
logger = logging.getLogger(__name__)
class StatusHandler(object): class StatusHandler(object):
""" Context wrapper for writing status to build logs. """ """ Context wrapper for writing status to build logs. """
@ -24,7 +29,11 @@ class StatusHandler(object):
def _append_log_message(self, log_message, log_type=None, log_data=None): def _append_log_message(self, log_message, log_type=None, log_data=None):
log_data = log_data or {} log_data = log_data or {}
log_data['datetime'] = str(datetime.datetime.now()) log_data['datetime'] = str(datetime.datetime.now())
self._build_logs.append_log_message(self._uuid, log_message, log_type, log_data)
try:
self._build_logs.append_log_message(self._uuid, log_message, log_type, log_data)
except RedisError:
logger.exception('Could not save build log for build %s: %s', self._uuid, log_message)
def append_log(self, log_message, extra_data=None): def append_log(self, log_message, extra_data=None):
if log_message is None: if log_message is None:
@ -64,4 +73,7 @@ class StatusHandler(object):
return self._status return self._status
def __exit__(self, exc_type, value, traceback): def __exit__(self, exc_type, value, traceback):
self._build_logs.set_status(self._uuid, self._status) try:
self._build_logs.set_status(self._uuid, self._status)
except RedisError:
logger.exception('Could not set status of build %s to %s', self._uuid, self._status)