vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix cannot-use-robot for private base image bug in build dialog

Browse source 
There are a number of small state fixes in this PR, which result in the build dialog being properly reset state-wise each time it is displayed, thus fixing the state inconsistency.

Fixes #2106
This commit is contained in:
Joseph Schorr 2016-11-10 14:47:25 -05:00
parent 6de039dc97
commit 3193f32a95
6 changed files with 44 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

6
static/directives/dockerfile-build-form.html
View file

@ -8,7 +8,8 @@
select-message="Please select a Dockerfile or an archive (.tar.gz or .zip) containing a Dockerfile at the root directory"
files-cleared="handleFilesCleared()"
files-selected="handleFilesSelected(files, callback)"
files-validated="handleFilesValidated(uploadFiles)"></div>
files-validated="handleFilesValidated(uploadFiles)"
reset="reset"></div>
<div class="robot-permission" ng-show="privateBaseRepository && state != 'uploading-files'">
<div class="help-text">
@ -27,6 +28,9 @@
Robot account <strong>{{ pullEntity.name }}</strong> does not have
read permission on repository <strong>{{ privateBaseRepository }}</strong>.
</div>
<div ng-if="state == 'checking-bot'" style="margin-top: 10px;">
<span class="cor-loader-inline"></span> Checking robot permissions...
</div>
</div>
</div>
</div>