vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Add missing $scope.$apply in the build logs view

Browse source 
Without this, the logs appear to never load, until such time as any other digest cycle comes along

Fixes #1886
This commit is contained in:
Joseph Schorr 2016-09-29 16:23:11 +02:00
parent 9def2cf055
commit 3476829139
1 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
static/js/directives/ui/build-logs-view.js
View file

@ -117,8 +117,11 @@ angular.module('quay').directive('buildLogsView', function () {
$.ajax({ $.ajax({
url: logsUrl, url: logsUrl,
}).done(function(r) { }).done(function(r) {
$scope.$apply(function() {
handleLogsData(r, callback); handleLogsData(r, callback);
});
}).error(function(xhr) { }).error(function(xhr) {
$scope.$apply(function() {
if (xhr.status == 0) { if (xhr.status == 0) {
UtilService.isAdBlockEnabled(function(result) { UtilService.isAdBlockEnabled(function(result) {
$scope.loadError = result ? 'blocked': 'request-failed'; $scope.loadError = result ? 'blocked': 'request-failed';
@ -127,6 +130,7 @@ angular.module('quay').directive('buildLogsView', function () {
$scope.loadError = 'request-failed'; $scope.loadError = 'request-failed';
} }
}); });
});
return; return;
} }