From 37a4dafe40ec52342098ab32828e6d7433fbec2c Mon Sep 17 00:00:00 2001 From: Quentin Machu Date: Thu, 22 Oct 2015 11:24:17 -0400 Subject: [PATCH] Use expected exception for BitBucket OAuth error Prevents from having a 500 when BitBucket OAuth doesn't work, as it will be caught in web.py/attach_bitbucket_trigger --- buildtrigger/bitbuckethandler.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/buildtrigger/bitbuckethandler.py b/buildtrigger/bitbuckethandler.py index 879448456..e14d75b09 100644 --- a/buildtrigger/bitbuckethandler.py +++ b/buildtrigger/bitbuckethandler.py @@ -300,7 +300,7 @@ class BitbucketBuildTrigger(BuildTriggerHandler): bitbucket_client = self._get_client() (result, data, err_msg) = bitbucket_client.get_authorization_url() if not result: - raise RepositoryReadException(err_msg) + raise TriggerProviderException(err_msg) return data @@ -547,4 +547,3 @@ class BitbucketBuildTrigger(BuildTriggerHandler): repository_name, lookup_author) return self.prepare_build(metadata, is_manual=True) -