vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Robot accounts allow underscores

Browse source 
Fixes #451
This commit is contained in:
Joseph Schorr 2015-09-08 10:10:00 -04:00
parent 46f150cafb
commit 386fcfd50e
2 changed files with 21 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
static/js/app.js
View file

@ -1,5 +1,5 @@
var TEAM_PATTERN = '^[a-zA-Z][a-zA-Z0-9]+$'; var TEAM_PATTERN = '^[a-zA-Z][a-zA-Z0-9]+$';
var ROBOT_PATTERN = '^[a-zA-Z][a-zA-Z0-9]{3,29}$'; var ROBOT_PATTERN = '^[a-zA-Z][a-zA-Z0-9_]{3,29}$';
var USER_PATTERN = '^[a-z0-9_]{4,30}$'; var USER_PATTERN = '^[a-z0-9_]{4,30}$';
// Define the pages module. // Define the pages module.

20
test/test_api_usage.py
View file

@ -2512,6 +2512,26 @@ class TestOrgRobots(ApiTestCase):
return [r['name'] for r in self.getJsonResponse(OrgRobotList, return [r['name'] for r in self.getJsonResponse(OrgRobotList,
params=dict(orgname=ORGANIZATION))['robots']] params=dict(orgname=ORGANIZATION))['robots']]
def test_create_robot_with_underscores(self):
self.login(ADMIN_ACCESS_USER)
# Create the robot.
self.putJsonResponse(OrgRobot,
params=dict(orgname=ORGANIZATION, robot_shortname='mr_bender'),
expected_code=201)
# Add the robot to a team.
membername = ORGANIZATION + '+mr_bender'
self.putJsonResponse(TeamMember,
params=dict(orgname=ORGANIZATION, teamname='readers',
membername=membername))
# Retrieve the robot's details.
self.getJsonResponse(OrgRobot,
params=dict(orgname=ORGANIZATION, robot_shortname='mr_bender'),
expected_code=200)
def test_delete_robot_after_use(self): def test_delete_robot_after_use(self):
self.login(ADMIN_ACCESS_USER) self.login(ADMIN_ACCESS_USER)