From 1cda2e1a62004050cb5331b6cebb7e76d4728643 Mon Sep 17 00:00:00 2001 From: Kenny Lee Sin Cheong Date: Wed, 24 Oct 2018 16:24:42 -0400 Subject: [PATCH 1/3] Fix undefined function name --- static/js/directives/ui/tag-operations-dialog.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/static/js/directives/ui/tag-operations-dialog.js b/static/js/directives/ui/tag-operations-dialog.js index 417a997a8..e437297ae 100644 --- a/static/js/directives/ui/tag-operations-dialog.js +++ b/static/js/directives/ui/tag-operations-dialog.js @@ -39,7 +39,7 @@ angular.module('quay').directive('tagOperationsDialog', function () { $.extend(tags, newTags); if (resp.has_additional) { - loadPaginatedRepositoryTags(page + 1, tags, added, removed); + reloadTags(page + 1, tags, added, removed); } else { $scope.repositoryTags = tags; $scope.imageLoader.reset(); From e61551d6b976bc8ab77856661f79506d78006b23 Mon Sep 17 00:00:00 2001 From: Kenny Lee Sin Cheong Date: Wed, 24 Oct 2018 17:35:02 -0400 Subject: [PATCH 2/3] Show loader when tags are loading instead of empty msg --- static/directives/repo-view/repo-panel-tags.html | 3 ++- static/js/pages/repo-view.js | 7 +++++-- static/partials/repo-view.html | 1 + 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/static/directives/repo-view/repo-panel-tags.html b/static/directives/repo-view/repo-panel-tags.html index d34fab7ff..665762e0a 100644 --- a/static/directives/repo-view/repo-panel-tags.html +++ b/static/directives/repo-view/repo-panel-tags.html @@ -341,7 +341,8 @@
Try expanding your filtering terms.
-
+
+
This repository is empty.
Push a tag or initiate a build to populate this repository.
diff --git a/static/js/pages/repo-view.js b/static/js/pages/repo-view.js index c3b04ba8d..cdd2b54bb 100644 --- a/static/js/pages/repo-view.js +++ b/static/js/pages/repo-view.js @@ -31,7 +31,8 @@ 'imageLoader': imageLoader, 'builds': null, 'historyFilter': '', - 'repositoryTags': null + 'repositoryTags': null, + 'tagsLoading': true }; $scope.repositoryTags = {}; @@ -77,7 +78,9 @@ if (resp.has_additional) { loadPaginatedRepositoryTags(page + 1); - } + } else { + $scope.viewScope.tagsLoading = false; + } }); }; diff --git a/static/partials/repo-view.html b/static/partials/repo-view.html index 046f63fc1..0074aae8c 100644 --- a/static/partials/repo-view.html +++ b/static/partials/repo-view.html @@ -77,6 +77,7 @@
Date: Tue, 30 Oct 2018 13:21:14 -0400 Subject: [PATCH 3/3] typo --- static/partials/repo-view.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/static/partials/repo-view.html b/static/partials/repo-view.html index 0074aae8c..5db77ff84 100644 --- a/static/partials/repo-view.html +++ b/static/partials/repo-view.html @@ -77,7 +77,7 @@