From c6b45298ad47187d42acbf6dc214f95b842dcf5c Mon Sep 17 00:00:00 2001 From: Joseph Schorr Date: Wed, 5 Apr 2017 14:11:06 -0400 Subject: [PATCH 1/3] Make app repos private by default --- endpoints/appr/registry.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/endpoints/appr/registry.py b/endpoints/appr/registry.py index f57036360..467a9cb07 100644 --- a/endpoints/appr/registry.py +++ b/endpoints/appr/registry.py @@ -188,7 +188,7 @@ def push(namespace, package_name): raise InvalidUsage() values = request.get_json(force=True, silent=True) or {} - private = values.get('visibility', 'public') + private = values.get('visibility', 'private') owner = get_authenticated_user() if not Package.exists(reponame): From 288ef0f5b50a0983e603ac601c3490102bccb86a Mon Sep 17 00:00:00 2001 From: Joseph Schorr Date: Wed, 5 Apr 2017 14:11:41 -0400 Subject: [PATCH 2/3] Add "(None)" into release channels column --- static/js/directives/ui/app-public-view/channels-list.html | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/static/js/directives/ui/app-public-view/channels-list.html b/static/js/directives/ui/app-public-view/channels-list.html index ca63c597d..2c5bd38dc 100644 --- a/static/js/directives/ui/app-public-view/channels-list.html +++ b/static/js/directives/ui/app-public-view/channels-list.html @@ -1,3 +1,4 @@ - \ No newline at end of file + +(None) \ No newline at end of file From c8ee889272dfc424dce831dee90be0a1d0223178 Mon Sep 17 00:00:00 2001 From: Joseph Schorr Date: Wed, 5 Apr 2017 14:19:37 -0400 Subject: [PATCH 3/3] Watch for changes in table data in corTable control Prevents stale data from appearing in the table --- .../js/directives/ui/cor-table/cor-table.component.ts | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/static/js/directives/ui/cor-table/cor-table.component.ts b/static/js/directives/ui/cor-table/cor-table.component.ts index feb681fb4..cc0e23c38 100644 --- a/static/js/directives/ui/cor-table/cor-table.component.ts +++ b/static/js/directives/ui/cor-table/cor-table.component.ts @@ -10,7 +10,7 @@ import { CorTableColumn } from './cor-table-col.component'; transclude: true, }) export class CorTableComponent implements ng.IComponentController { - @Input('=') public tableData: any[]; + @Input('<') public tableData: any[]; @Input('@') public tableItemTitle: string; @Input('<') public filterFields: string[]; @Input('@') public compact: string; @@ -30,6 +30,12 @@ export class CorTableComponent implements ng.IComponentController { }; } + public $onChanges(changes: ng.IOnChangesObject): void { + if (changes['tableData'] !== undefined) { + this.refreshOrder(); + } + } + public addColumn(col: CorTableColumn): void { this.columns.push(col); @@ -64,7 +70,8 @@ export class CorTableComponent implements ng.IComponentController { return col.isNumeric(); }).map((col) => (col.datafield)); - var processed = this.tableData.map((item) => { + var tableData = this.tableData || []; + var processed = tableData.map((item) => { var keys = Object.keys(item); var newObj = {}; for (var i = 0; i < keys.length; ++i) {