Start refactoring of the trigger system:

- Move each trigger handler into its own file
- Add dictionary helper classes for easier reading and writing of dict-based data
- Extract the web hook payload -> internal representation building for each trigger system
- Add tests for this transformation
- Remove support for Github archived-based building

buildtrigger/triggerutil.py

@@ -0,0 +1,121 @@
+import json
+import io
+import logging
+import re
+
+class InvalidPayloadException(Exception):
+  pass
+
+class BuildArchiveException(Exception):
+  pass
+
+class InvalidServiceException(Exception):
+  pass
+
+class TriggerActivationException(Exception):
+  pass
+
+class TriggerDeactivationException(Exception):
+  pass
+
+class TriggerStartException(Exception):
+  pass
+
+class ValidationRequestException(Exception):
+  pass
+
+class SkipRequestException(Exception):
+  pass
+
+class EmptyRepositoryException(Exception):
+  pass
+
+class RepositoryReadException(Exception):
+  pass
+
+class TriggerProviderException(Exception):
+  pass
+
+logger = logging.getLogger(__name__)
+
+def determine_build_ref(run_parameters, get_branch_sha, get_tag_sha, default_branch):
+  run_parameters = run_parameters or {}
+
+  kind = ''
+  value = ''
+
+  if 'refs' in run_parameters and run_parameters['refs']:
+    kind = run_parameters['refs']['kind']
+    value = run_parameters['refs']['name']
+  elif 'branch_name' in run_parameters:
+    kind = 'branch'
+    value = run_parameters['branch_name']
+
+  kind = kind or 'branch'
+  value = value or default_branch
+
+  ref = 'refs/tags/' + value if kind == 'tag' else 'refs/heads/' + value
+  commit_sha = get_tag_sha(value) if kind == 'tag' else get_branch_sha(value)
+  return (commit_sha, ref)
+
+
+def find_matching_branches(config, branches):
+  if 'branchtag_regex' in config:
+    try:
+      regex = re.compile(config['branchtag_regex'])
+      return [branch for branch in branches
+              if matches_ref('refs/heads/' + branch, regex)]
+    except:
+      pass
+
+  return branches
+
+
+def should_skip_commit(message):
+  return '[skip build]' in message or '[build skip]' in message
+
+
+def raise_if_skipped_build(prepared_build):
+  """ Raises a SkipRequestException if the given build should be skipped. """
+  if not prepared_build.metadata:
+    logger.debug('Skipping request due to missing metadata for prepared build')
+    raise SkipRequestException()
+
+  if should_skip_commit(prepared_build.metadata['commit_info']['message']):
+    logger.debug('Skipping request due to commit message request')
+    raise SkipRequestException()
+
+
+def raise_if_skipped(config, ref):
+  """ Raises a SkipRequestException if the given ref should be skipped. """
+  if 'branchtag_regex' in config:
+    try:
+      regex = re.compile(config['branchtag_regex'])
+    except:
+      regex = re.compile('.*')
+
+    if not matches_ref(ref, regex):
+      raise SkipRequestException()
+
+
+def matches_ref(ref, regex):
+  match_string = ref.split('/', 1)[1]
+  if not regex:
+    return False
+
+  m = regex.match(match_string)
+  if not m:
+    return False
+
+  return len(m.group(0)) == len(match_string)
+
+
+def raise_unsupported():
+  raise io.UnsupportedOperation
+
+
+def get_trigger_config(trigger):
+  try:
+    return json.loads(trigger.config)
+  except ValueError:
+    return {}