vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Don't add a "password required" notification for non-database auth via OIDC

Browse source
This commit is contained in:
Joseph Schorr 2017-11-10 16:49:32 -05:00
parent d32139292b
commit 503cff8f0c
6 changed files with 30 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
endpoints/oauth/login.py
View file

@ -105,9 +105,10 @@ def _conduct_oauth_login(auth_system, login_service, lid, lusername, lemail, met
new_username = valid
break
requires_password = auth_system.requires_distinct_cli_password
prompts = model.user.get_default_user_prompts(features)
user_obj = model.user.create_federated_user(new_username, lemail, service_id, lid,
set_password_notification=True,
set_password_notification=requires_password,
metadata=metadata or {},
prompts=prompts,
email_required=features.MAILING)

7
endpoints/oauth/test/test_login.py
View file

@ -73,6 +73,10 @@ def test_new_account_via_database(login_service):
federated_login = model.user.lookup_federated_login(new_user, login_service.service_id())
assert federated_login is not None
# Ensure that a notification was created.
assert list(model.notification.list_notifications(result.user_obj,
kind_name='password_required'))
@pytest.mark.parametrize('open_creation, invite_only, has_invite, expect_success', [
# Open creation -> Success!
(True, False, False, True),
@ -173,6 +177,9 @@ def test_new_account_via_ldap(binding_field, lid, lusername, lemail, expected_er
else:
assert internal_login is None
# Ensure that no notification was created.
assert not list(model.notification.list_notifications(result.user_obj,
kind_name='password_required'))
else:
# Ensure that no addtional users were created.
assert current_user_count == existing_user_count