vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Add support for POST calls to OIDC endpoints

Browse source
This commit is contained in:
Joseph Schorr 2018-09-07 14:52:00 -04:00
parent f9414c256d
commit 5240140a96
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
endpoints/oauth/login.py
View file

@ -182,12 +182,12 @@ def _register_service(login_service):
@oauthlogin_csrf_protect @oauthlogin_csrf_protect
def callback_func(): def callback_func():
# Check for a callback error. # Check for a callback error.
error = request.args.get('error', None) error = request.values.get('error', None)
if error: if error:
return _render_ologin_error(login_service.service_name(), error) return _render_ologin_error(login_service.service_name(), error)
# Exchange the OAuth code for login information. # Exchange the OAuth code for login information.
code = request.args.get('code') code = request.values.get('code')
try: try:
lid, lusername, lemail = login_service.exchange_code_for_login(app.config, client, code, '') lid, lusername, lemail = login_service.exchange_code_for_login(app.config, client, code, '')
except OAuthLoginException as ole: except OAuthLoginException as ole:
@ -217,12 +217,12 @@ def _register_service(login_service):
@oauthlogin_csrf_protect @oauthlogin_csrf_protect
def attach_func(): def attach_func():
# Check for a callback error. # Check for a callback error.
error = request.args.get('error', None) error = request.values.get('error', None)
if error: if error:
return _render_ologin_error(login_service.service_name(), error) return _render_ologin_error(login_service.service_name(), error)
# Exchange the OAuth code for login information. # Exchange the OAuth code for login information.
code = request.args.get('code') code = request.values.get('code')
try: try:
lid, lusername, _ = login_service.exchange_code_for_login(app.config, client, code, '/attach') lid, lusername, _ = login_service.exchange_code_for_login(app.config, client, code, '/attach')
except OAuthLoginException as ole: except OAuthLoginException as ole:
@ -258,12 +258,12 @@ def _register_service(login_service):
@oauthlogin_csrf_protect @oauthlogin_csrf_protect
def cli_token_func(): def cli_token_func():
# Check for a callback error. # Check for a callback error.
error = request.args.get('error', None) error = request.values.get('error', None)
if error: if error:
return _render_ologin_error(login_service.service_name(), error) return _render_ologin_error(login_service.service_name(), error)
# Exchange the OAuth code for the ID token. # Exchange the OAuth code for the ID token.
code = request.args.get('code') code = request.values.get('code')
try: try:
idtoken, _ = login_service.exchange_code_for_tokens(app.config, client, code, '/cli') idtoken, _ = login_service.exchange_code_for_tokens(app.config, client, code, '/cli')
except OAuthLoginException as ole: except OAuthLoginException as ole:
@ -281,17 +281,17 @@ def _register_service(login_service):
oauthlogin.add_url_rule('/%s/callback' % login_service.service_id(), oauthlogin.add_url_rule('/%s/callback' % login_service.service_id(),
'%s_oauth_callback' % login_service.service_id(), '%s_oauth_callback' % login_service.service_id(),
callback_func, callback_func,
methods=['GET']) methods=['GET', 'POST'])
oauthlogin.add_url_rule('/%s/callback/attach' % login_service.service_id(), oauthlogin.add_url_rule('/%s/callback/attach' % login_service.service_id(),
'%s_oauth_attach' % login_service.service_id(), '%s_oauth_attach' % login_service.service_id(),
attach_func, attach_func,
methods=['GET']) methods=['GET', 'POST'])
oauthlogin.add_url_rule('/%s/callback/cli' % login_service.service_id(), oauthlogin.add_url_rule('/%s/callback/cli' % login_service.service_id(),
'%s_oauth_cli' % login_service.service_id(), '%s_oauth_cli' % login_service.service_id(),
cli_token_func, cli_token_func,
methods=['GET']) methods=['GET', 'POST'])
# Register the routes for each of the login services. # Register the routes for each of the login services.
for current_service in oauth_login.services: for current_service in oauth_login.services: