vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Merge pull request #2492 from alecmerdler/fix-build-service

Browse source 
Null Case for Frontend Retrieving Build Message
This commit is contained in:
Alec Merdler 2017-03-29 13:48:49 -07:00 committed by GitHub
commit 52eab1766a
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
static/js/services/build/build.service.impl.spec.ts
View file

@ -37,6 +37,7 @@ describe("BuildServiceImpl", () => {
beforeEach(() => {
buildMessages = [
{phase: null, message: ""},
{phase: 'cannot_load', message: 'Cannot load build status'},
{phase: 'starting', message: 'Starting Dockerfile build'},
{phase: 'initializing', message: 'Starting Dockerfile build'},
@ -69,7 +70,7 @@ describe("BuildServiceImpl", () => {
buildServiceImpl.getBuildMessage(phase);
fail("Should throw error");
} catch (error) {
expect(error.message).toEqual("Invalid build phase");
expect(error.message).toEqual(`Invalid build phase: ${phase.toString()}`);
}
});
});

6
static/js/services/build/build.service.impl.ts
View file

@ -14,6 +14,10 @@ export class BuildServiceImpl implements BuildService {
public getBuildMessage(phase: string): string {
var message: string;
switch (phase) {
case null:
message = '';
break;
case 'cannot_load':
message = 'Cannot load build status';
break;
@ -76,7 +80,7 @@ export class BuildServiceImpl implements BuildService {
break;
default:
throw new Error("Invalid build phase");
throw new Error(`Invalid build phase: ${phase.toString()}`);
}
return message;