vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix all target="_blank" anchors to be safer

Browse source 
Fixes #1411
This commit is contained in:
Joseph Schorr 2016-04-28 14:38:22 -04:00
parent 9e88b1413d
commit 54e8e72ad2
39 changed files with 76 additions and 66 deletions
Download patch file Download diff file Expand all files Collapse all files

4
static/directives/triggered-build-description.html
View file

@ -28,7 +28,7 @@
<div class="tbd-content" ng-switch-when="fullcommit">
<div class="commit-message">
<span class="anchor" is-only-text="!TriggerService.getFullLinkTemplate(build, 'commit')"
target="_blank" href="{{ TriggerService.getFullLinkTemplate(build, 'commit').replace('{sha}', TriggerService.getCommitSHA(build.trigger_metadata)) }}">
ng-safenewtab href="{{ TriggerService.getFullLinkTemplate(build, 'commit').replace('{sha}', TriggerService.getCommitSHA(build.trigger_metadata)) }}">
{{ getMessageSummary(build.trigger_metadata.commit_info.message) }}
</span>
<span class="long-description-toggle"
@ -44,7 +44,7 @@
<span class="anchor commit-who"
href="{{ build.trigger_metadata.commit_info.author.url }}"
is-only-text="!build.trigger_metadata.commit_info.author.url"
target="_blank">
ng-safenewtab>
<img ng-src="{{ build.trigger_metadata.commit_info.author.avatar_url }}"
ng-if="build.trigger_metadata.commit_info.author.avatar_url">
{{ build.trigger_metadata.commit_info.author.username }}