Get UI for activating github build triggers in place and working. Note that the actual server-side activation is still not done (but the proper method is invoked)

This commit is contained in:
Joseph Schorr 2014-02-20 18:57:49 -05:00
parent c494c889f5
commit 5519d93a64
8 changed files with 388 additions and 15 deletions

View file

@ -25,8 +25,11 @@ from auth.permissions import (ReadRepositoryPermission,
CreateRepositoryPermission,
AdministerOrganizationPermission,
OrganizationMemberPermission,
ViewTeamPermission)
ViewTeamPermission,
UserPermission
)
from endpoints.common import common_login, get_route_data
from endpoints.trigger import BuildTrigger, TriggerActivationException
from util.cache import cache_control
from datetime import datetime, timedelta
@ -1120,11 +1123,14 @@ def get_repo(namespace, repository):
def trigger_view(trigger):
if trigger and trigger.uuid:
config_dict = json.loads(trigger.config)
build_trigger = BuildTrigger.get_trigger_for_service(trigger.service.name)
return {
'service': trigger.service.name,
'config': json.loads(trigger.config),
'config': config_dict,
'id': trigger.uuid,
'connected_user': trigger.connected_user.username,
'is_active': build_trigger.is_active(config_dict)
}
return None
@ -1358,6 +1364,44 @@ def get_build_trigger(namespace, repository, trigger_uuid):
abort(403) # Permission denied
@api.route('/repository/<path:repository>/trigger/<trigger_uuid>/activate',
methods=['POST'])
@api_login_required
@parse_repository_name
def activate_build_trigger(namespace, repository, trigger_uuid):
permission = AdministerRepositoryPermission(namespace, repository)
if permission.can():
try:
trigger = model.get_build_trigger(namespace, repository, trigger_uuid)
except model.InvalidBuildTriggerException:
abort(404)
return
handler = BuildTrigger.get_trigger_for_service(trigger.service.name)
existing_config_dict = json.loads(trigger.config)
if handler.is_active(existing_config_dict):
abort(400)
return
user_permission = UserPermission(trigger.connected_user.username)
if user_permission.can():
new_config_dict = request.get_json()
try:
handler.activate(trigger.auth_token, new_config_dict)
except TriggerActivationException as e:
abort(400, message = e.msg)
return
# Save the updated config.
trigger.config = json.dumps(new_config_dict)
trigger.save()
return jsonify(trigger_view(trigger))
abort(403) # Permission denied
@api.route('/repository/<path:repository>/trigger/<trigger_uuid>/builds',
methods=['GET'])
@api_login_required
@ -1374,6 +1418,31 @@ def list_trigger_recent_builds(namespace, repository, trigger_uuid):
abort(403) # Permission denied
@api.route('/repository/<path:repository>/trigger/<trigger_uuid>/sources',
methods=['GET'])
@api_login_required
@parse_repository_name
def list_trigger_build_sources(namespace, repository, trigger_uuid):
permission = AdministerRepositoryPermission(namespace, repository)
if permission.can():
try:
trigger = model.get_build_trigger(namespace, repository, trigger_uuid)
except model.InvalidBuildTriggerException:
abort(404)
user_permission = UserPermission(trigger.connected_user.username)
if user_permission.can():
trigger_handler = BuildTrigger.get_trigger_for_service(trigger.service.name)
return jsonify({
'sources': trigger_handler.list_build_sources(trigger.auth_token)
})
abort(403) # Permission denied
@api.route('/repository/<path:repository>/trigger/', methods=['GET'])
@api_login_required
@parse_repository_name