From 55b1ad49edfe208fbb8726e452a6da90ee5d4684 Mon Sep 17 00:00:00 2001 From: Joseph Schorr Date: Mon, 3 Apr 2017 15:35:44 -0400 Subject: [PATCH] Make team API decorators more descriptive for better readability --- endpoints/api/team.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/endpoints/api/team.py b/endpoints/api/team.py index 320d008ad..981e0f1cc 100644 --- a/endpoints/api/team.py +++ b/endpoints/api/team.py @@ -120,6 +120,10 @@ def disallow_for_synced_team(except_robots=False): return inner +disallow_nonrobots_for_synced_team = disallow_for_synced_team(except_robots=True) +disallow_all_for_synced_team = disallow_for_synced_team(except_robots=False) + + @resource('/v1/organization//team/') @path_param('orgname', 'The name of the organization') @path_param('teamname', 'The name of the team') @@ -325,7 +329,7 @@ class TeamMember(ApiResource): @require_scope(scopes.ORG_ADMIN) @nickname('updateOrganizationTeamMember') - @disallow_for_synced_team(except_robots=True) + @disallow_nonrobots_for_synced_team def put(self, orgname, teamname, membername): """ Adds or invites a member to an existing team. """ permission = AdministerOrganizationPermission(orgname) @@ -363,7 +367,7 @@ class TeamMember(ApiResource): @require_scope(scopes.ORG_ADMIN) @nickname('deleteOrganizationTeamMember') - @disallow_for_synced_team(except_robots=True) + @disallow_nonrobots_for_synced_team def delete(self, orgname, teamname, membername): """ Delete a member of a team. If the user is merely invited to join the team, then the invite is removed instead. @@ -407,7 +411,7 @@ class InviteTeamMember(ApiResource): """ Resource for inviting a team member via email address. """ @require_scope(scopes.ORG_ADMIN) @nickname('inviteTeamMemberEmail') - @disallow_for_synced_team() + @disallow_all_for_synced_team def put(self, orgname, teamname, email): """ Invites an email address to an existing team. """ permission = AdministerOrganizationPermission(orgname)