vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

handle undefined case in BuildService#getBuildMessage

Browse source
This commit is contained in:
alecmerdler 2017-03-31 13:53:42 -07:00
parent 484ecd961e
commit 57beee6c69
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
static/js/services/build/build.service.impl.spec.ts
View file

@ -33,10 +33,11 @@ describe("BuildServiceImpl", () => {
}); });
describe("getBuildMessage", () => { describe("getBuildMessage", () => {
var buildMessages: {phase: string, message: string}[]; var buildMessages: {phase?: string, message: string}[];
beforeEach(() => { beforeEach(() => {
buildMessages = [ buildMessages = [
{message: ""},
{phase: null, message: ""}, {phase: null, message: ""},
{phase: 'cannot_load', message: 'Cannot load build status'}, {phase: 'cannot_load', message: 'Cannot load build status'},
{phase: 'starting', message: 'Starting Dockerfile build'}, {phase: 'starting', message: 'Starting Dockerfile build'},

1
static/js/services/build/build.service.impl.ts
View file

@ -15,6 +15,7 @@ export class BuildServiceImpl implements BuildService {
var message: string; var message: string;
switch (phase) { switch (phase) {
case null: case null:
case undefined:
message = ''; message = '';
break; break;