vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Make absolutely sure we don't overwrite an existing storage checksum

Browse source 
Old V1 code would occasionally do so, which was never correct, but we never hit it because we didn't (practically) share storage rows before. Now that we explicitly do, we were occasionally de-checksum-ing storage rows on V1 pushes (which are extremely rare as-is). This change makes sure we don't do that, and makes sure we always set a proper digest and checksum on storage rows.
This commit is contained in:
Joseph Schorr 2019-02-16 12:40:53 -05:00
parent 127174fcf7
commit 59e4896dbf
2 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
data/model/image.py
View file

@ -341,9 +341,6 @@ def set_image_metadata(docker_image_id, namespace_name, repository_name, created
# We cleanup any old checksum in case it's a retry after a fail
fetched.v1_checksum = None
fetched.storage.content_checksum = None
fetched.storage.save()
fetched.comment = comment
fetched.command = command
fetched.v1_json_metadata = v1_json_metadata