Add better (jinja-based) messaging to the notifications and add some fixes for the email templates

endpoints/notificationmethod.py

@@ -279,6 +279,7 @@ class HipchatMethod(NotificationMethod):
       'info': 'gray',
       'warning': 'yellow',
       'error': 'red',
+      'success': 'green',
       'primary': 'purple'
     }.get(level, 'gray')
 
@@ -303,6 +304,56 @@ class HipchatMethod(NotificationMethod):
       raise NotificationMethodPerformException(ex.message)
 
 
+from HTMLParser import HTMLParser
+
+class SlackAdjuster(HTMLParser):
+  def __init__(self):
+    self.reset()
+    self.result = []
+
+  def handle_data(self, d):
+    self.result.append(d)
+
+  def get_attr(self, attrs, name):
+    for attr in attrs:
+      if attr[0] == name:
+        return attr[1]
+
+    return ''
+
+  def handle_starttag(self, tag, attrs):
+    if tag == 'a':
+      self.result.append('<%s|' % (self.get_attr(attrs, 'href'), ))
+
+    if tag == 'i':
+      self.result.append('_')
+
+    if tag == 'b' or tag == 'strong':
+      self.result.append('*')
+
+    if tag == 'img':
+      self.result.append(self.get_attr(attrs, 'alt'))
+      self.result.append(' ')
+
+  def handle_endtag(self, tag):
+    if tag == 'a':
+      self.result.append('>')
+
+    if tag == 'b' or tag == 'strong':
+      self.result.append('*')
+
+    if tag == 'i':
+      self.result.append('_')
+
+  def get_data(self):
+    return ''.join(self.result)
+
+def adjust_tags(html):
+  s = SlackAdjuster()
+  s.feed(html)
+  return s.get_data()
+
+
 class SlackMethod(NotificationMethod):
   """ Method for sending notifications to Slack via the API:
       https://api.slack.com/docs/attachments
@@ -318,12 +369,11 @@ class SlackMethod(NotificationMethod):
     if not config_data.get('subdomain', '').isalnum():
       raise CannotValidateNotificationMethodException('Missing Slack Subdomain Name')
 
-  def formatForSlack(self, message):
+  def format_for_slack(self, message):
     message = message.replace('\n', '')
     message = re.sub(r'\s+', ' ', message)
     message = message.replace('<br>', '\n')
-    message = re.sub(r'<a href="(.+)">(.+)</a>', '<\\1|\\2>', message)
-    return message
+    return adjust_tags(message)
 
   def perform(self, notification, event_handler, notification_data):
     config_data = json.loads(notification.config_json)
@@ -346,6 +396,7 @@ class SlackMethod(NotificationMethod):
       'info': '#ffffff',
       'warning': 'warning',
       'error': 'danger',
+      'success': 'good',
       'primary': 'good'
     }.get(level, '#ffffff')
 
@@ -359,8 +410,9 @@ class SlackMethod(NotificationMethod):
       'attachments': [
         {
           'fallback': summary,
-          'text': self.formatForSlack(message),
-          'color': color
+          'text': self.format_for_slack(message),
+          'color': color,
+          'mrkdwn_in': ["text"]
         }
       ]
     }