vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

fix(frontend): fixed changing location

Browse source 
before we were setting the location on the window when we should have been just using Angular $location service instead

[TESTING -> tested locally with docker compose and a complete build]

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
This commit is contained in:
Charlton Austin 2017-05-05 15:10:06 -04:00
parent a6b7560fdc
commit 6e533e3627
4 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

3
static/js/directives/ui/signup-form.js
View file

@ -38,7 +38,8 @@ angular.module('quay').directive('signupForm', function () {
$scope.userRegistered({'username': $scope.newUser.username});
if (!$scope.awaitingConfirmation && !$scope.inviteCode) {
document.location = '/';
$location.path("/");
}
UserService.load();

4
static/js/directives/ui/teams-manager.js
View file

@ -12,7 +12,7 @@ angular.module('quay').directive('teamsManager', function () {
'organization': '=organization',
'isEnabled': '=isEnabled'
},
controller: function($scope, $element, ApiService, $timeout, UserService, TableService, UIService, Config, Features) {
controller: function($scope, $element, ApiService, $timeout, UserService, TableService, UIService, Config, Features, $location) {
$scope.TableService = TableService;
$scope.Config = Config;
$scope.Features = Features;
@ -151,7 +151,7 @@ angular.module('quay').directive('teamsManager', function () {
};
$scope.viewTeam = function(teamName) {
document.location = '/organization/' + $scope.organization.name + '/teams/' + teamName;
$location.path('/organization/' + $scope.organization.name + '/teams/' + teamName);
};
$scope.showMembers = function(value) {

7
static/js/pages/build-view.js
View file

@ -10,7 +10,7 @@
});
}]);
function BuildViewCtrl($scope, ApiService, $routeParams, AngularPollChannel, CookieService) {
function BuildViewCtrl($scope, ApiService, $routeParams, AngularPollChannel, CookieService, $location) {
$scope.namespace = $routeParams.namespace;
$scope.name = $routeParams.name;
$scope.build_uuid = $routeParams.buildid;
@ -51,8 +51,9 @@
'build_uuid': build.id
};
ApiService.cancelRepoBuild(null, params).then(function() {
document.location = '/repository/' + $scope.namespace + '/' + $scope.name;
ApiService.cancelRepoBuild(null, params).then(function () {
$location.path('/repository/' + $scope.namespace + '/' + $scope.name);
}, ApiService.errorDisplay('Cannot cancel build'));
}
});

8
static/js/services/plan-service.js
View file

@ -2,9 +2,9 @@
* Helper service for loading, changing and working with subscription plans.
*/
angular.module('quay')
.factory('PlanService', ['KeyService', 'UserService', 'CookieService', 'ApiService', 'Features', 'Config',
.factory('PlanService', ['KeyService', 'UserService', 'CookieService', 'ApiService', 'Features', 'Config', '$location',
function(KeyService, UserService, CookieService, ApiService, Features, Config) {
function(KeyService, UserService, CookieService, ApiService, Features, Config, $location) {
var plans = null;
var planDict = {};
var planService = {};
@ -67,9 +67,9 @@ function(KeyService, UserService, CookieService, ApiService, Features, Config) {
planService.getPlan(planId, function(plan) {
if (planService.isOrgCompatible(plan)) {
document.location = '/organizations/new/?plan=' + planId;
$location.path('/organizations/new/?plan=' + planId);
} else {
document.location = '/user?plan=' + planId;
$location.path('/user?plan=' + planId);
}
});
});