Add tests for build web hooks endpoint

This commit is contained in:
Joseph Schorr 2017-03-20 13:22:59 -04:00
parent 0ea600628b
commit 6f567e0850
7 changed files with 64 additions and 12 deletions

View file

@ -530,6 +530,8 @@ class GithubBuildTrigger(BuildTriggerHandler):
def handle_trigger_request(self, request):
# Check the payload to see if we should skip it based on the lack of a head_commit.
payload = request.get_json()
if payload is None:
raise InvalidPayloadException('Missing payload')
# This is for GitHub's probing/testing.
if 'zen' in payload:
@ -537,16 +539,16 @@ class GithubBuildTrigger(BuildTriggerHandler):
# Lookup the default branch for the repository.
if 'repository' not in payload:
raise ValidationRequestException("Missing 'repository' on request")
raise InvalidPayloadException("Missing 'repository' on request")
if 'owner' not in payload['repository']:
raise ValidationRequestException("Missing 'owner' on repository")
raise InvalidPayloadException("Missing 'owner' on repository")
if 'name' not in payload['repository']['owner']:
raise ValidationRequestException("Missing owner 'name' on repository")
raise InvalidPayloadException("Missing owner 'name' on repository")
if 'name' not in payload['repository']:
raise ValidationRequestException("Missing 'name' on repository")
raise InvalidPayloadException("Missing 'name' on repository")
default_branch = None
lookup_user = None