Add tests for build web hooks endpoint

test/test_endpoints.py

@@ -24,6 +24,7 @@ from endpoints.api.user import Signin
 from endpoints.keyserver import jwk_with_kid
 from endpoints.csrf import OAUTH_CSRF_TOKEN_NAME
 from endpoints.web import web as web_bp
+from endpoints.webhooks import webhooks as webhooks_bp
 from initdb import setup_database_for_testing, finished_database_for_testing
 from test.helpers import assert_action_logged
 
@@ -33,6 +34,12 @@ except ValueError:
   # This blueprint was already registered
   pass
 
+try:
+  app.register_blueprint(webhooks_bp, url_prefix='/webhooks')
+except ValueError:
+  # This blueprint was already registered
+  pass
+
 try:
   app.register_blueprint(keyserver.key_server, url_prefix='')
 except ValueError:
@@ -101,14 +108,20 @@ class EndpointTestCase(unittest.TestCase):
     self.assertEquals(rv.status_code, expected_code)
     return rv.data
 
-  def postResponse(self, resource_name, headers=None, form=None, with_csrf=True, expected_code=200, **kwargs):
+  def postResponse(self, resource_name, headers=None, data=None, form=None, with_csrf=True, expected_code=200, **kwargs):
     headers = headers or {}
     form = form or {}
     url = url_for(resource_name, **kwargs)
     if with_csrf:
       url = EndpointTestCase._add_csrf(url)
 
-    rv = self.app.post(url, headers=headers, data=form)
+    post_data = None
+    if form:
+      post_data = form
+    elif data:
+      post_data = py_json.dumps(data)
+
+    rv = self.app.post(url, headers=headers, data=post_data)
     if expected_code is not None:
       self.assertEquals(rv.status_code, expected_code)
 
@@ -121,6 +134,38 @@ class EndpointTestCase(unittest.TestCase):
     self.assertEquals(rv.status_code, 200)
 
 
+class WebhookEndpointTestCase(EndpointTestCase):
+  def test_invalid_build_trigger_webhook(self):
+    self.postResponse('webhooks.build_trigger_webhook', trigger_uuid='invalidtrigger',
+                      expected_code=404)
+
+  def test_valid_build_trigger_webhook_invalid_auth(self):
+    trigger = list(model.build.list_build_triggers('devtable', 'building'))[0]
+    self.postResponse('webhooks.build_trigger_webhook', trigger_uuid=trigger.uuid,
+                      expected_code=403)
+
+  def test_valid_build_trigger_webhook_cookie_auth(self):
+    self.login('devtable', 'password')
+
+    # Cookie auth is not supported, so this should 403
+    trigger = list(model.build.list_build_triggers('devtable', 'building'))[0]
+    self.postResponse('webhooks.build_trigger_webhook', trigger_uuid=trigger.uuid,
+                      expected_code=403)
+
+  def test_valid_build_trigger_webhook_missing_payload(self):
+    auth_header = 'Basic %s' % (base64.b64encode('devtable:password'))
+    trigger = list(model.build.list_build_triggers('devtable', 'building'))[0]
+    self.postResponse('webhooks.build_trigger_webhook', trigger_uuid=trigger.uuid,
+                      expected_code=400, headers={'Authorization': auth_header})
+
+  def test_valid_build_trigger_webhook_invalid_payload(self):
+    auth_header = 'Basic %s' % (base64.b64encode('devtable:password'))
+    trigger = list(model.build.list_build_triggers('devtable', 'building'))[0]
+    self.postResponse('webhooks.build_trigger_webhook', trigger_uuid=trigger.uuid,
+                      expected_code=400,
+                      headers={'Authorization': auth_header, 'Content-Type': 'application/json'},
+                      data={'invalid': 'payload'})
+
 class WebEndpointTestCase(EndpointTestCase):
   def test_index(self):
     self.getResponse('web.index')