diff --git a/static/directives/source-commit-link.html b/static/directives/source-commit-link.html index 637cf875d..7cae72bc3 100644 --- a/static/directives/source-commit-link.html +++ b/static/directives/source-commit-link.html @@ -3,7 +3,7 @@ + is-only-text="!urlTemplate || !getUrl(commitSha, urlTemplate)"> {{ commitSha.substring(0, 8) }} diff --git a/static/directives/source-ref-link.html b/static/directives/source-ref-link.html index 201b0bc0b..d68e97594 100644 --- a/static/directives/source-ref-link.html +++ b/static/directives/source-ref-link.html @@ -3,13 +3,13 @@ - {{ getTitle(ref) }} + {{ getTitle(ref) }} - {{ getTitle(ref) }} + {{ getTitle(ref) }} diff --git a/static/js/directives/ui/source-commit-link.js b/static/js/directives/ui/source-commit-link.js index 2859aaa61..8ef732bff 100644 --- a/static/js/directives/ui/source-commit-link.js +++ b/static/js/directives/ui/source-commit-link.js @@ -15,6 +15,7 @@ angular.module('quay').directive('sourceCommitLink', function () { }, controller: function($scope, $element) { $scope.getUrl = function(sha, template) { + if (!template) { return ''; } return template.replace('{sha}', sha); }; } diff --git a/static/js/directives/ui/source-ref-link.js b/static/js/directives/ui/source-ref-link.js index 170ff3f04..d8ee3d4c3 100644 --- a/static/js/directives/ui/source-ref-link.js +++ b/static/js/directives/ui/source-ref-link.js @@ -33,6 +33,7 @@ angular.module('quay').directive('sourceRefLink', function () { }; $scope.getUrl = function(ref, template, kind) { + if (!template) { return ''; } return template.replace('{' + kind + '}', $scope.getTitle(ref)); }; }