vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Change manifest backfill to lookup missing content checksums in the repository

Browse source 
After discussion, we decided the best solution for the missing content checksum problem was to lookup the proper blobs in the repository and, if not present, mark the manifest as broken, as this would reflect the actual issue the user faces if they pull the repository tag today via V2
This commit is contained in:
Joseph Schorr 2018-08-14 14:36:19 -04:00
parent c0d25d3149
commit 70df10dade
3 changed files with 92 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
data/model/tag.py
View file

@ -606,7 +606,7 @@ def associate_generated_tag_manifest(namespace, repo_name, tag_name, manifest, s
def _create_manifest(tag, manifest, storage_id_map):
storage_ids = set()
for blob_digest in reversed(manifest.blob_digests):
for blob_digest in manifest.blob_digests:
image_storage_id = storage_id_map.get(blob_digest)
if image_storage_id is None:
logger.error('Missing blob for manifest `%s` in: %s', blob_digest, storage_id_map)