From 7380cf0ce0d9a79d483bca554fe08a1cf173b436 Mon Sep 17 00:00:00 2001 From: Joseph Schorr Date: Thu, 29 Sep 2016 16:34:26 +0200 Subject: [PATCH] Show a throbber when the Angular view array still has hidden entries This provides slightly better UI feedback to the user that more logs are incoming Fixes #1881 --- static/directives/build-logs-view.html | 3 +++ static/js/services/angular-view-array.js | 2 ++ 2 files changed, 5 insertions(+) diff --git a/static/directives/build-logs-view.html b/static/directives/build-logs-view.html index e5f0d2915..00a5fbbf8 100644 --- a/static/directives/build-logs-view.html +++ b/static/directives/build-logs-view.html @@ -64,6 +64,9 @@ +
+
+
diff --git a/static/js/services/angular-view-array.js b/static/js/services/angular-view-array.js index 2e0e6594a..9ccd0df20 100644 --- a/static/js/services/angular-view-array.js +++ b/static/js/services/angular-view-array.js @@ -11,6 +11,7 @@ angular.module('quay').factory('AngularViewArray', ['$interval', function($inter this.visibleEntries = null; this.hasEntries = false; this.entries = []; + this.hasHiddenEntries = false; this.timerRef_ = null; this.currentIndex_ = 0; @@ -58,6 +59,7 @@ angular.module('quay').factory('AngularViewArray', ['$interval', function($inter } this.currentIndex_ = i; + this.hasHiddenEntries = this.currentIndex_ < this.entries.length; if (this.currentIndex_ >= this.entries.length) { this.stopTimer_(); }