From 738c4a86ffe2921609fc7dede608cf008afed9c5 Mon Sep 17 00:00:00 2001 From: Joseph Schorr Date: Wed, 4 Jun 2014 16:12:31 -0400 Subject: [PATCH] Check to make sure we can load the github user data --- endpoints/callbacks.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/endpoints/callbacks.py b/endpoints/callbacks.py index 9727d8847..015f3c3a7 100644 --- a/endpoints/callbacks.py +++ b/endpoints/callbacks.py @@ -61,6 +61,8 @@ def github_oauth_callback(): token = exchange_github_code_for_token(request.args.get('code')) user_data = get_github_user(token) + if not user_data: + return render_page_template('githuberror.html', error_message='Could not load user data') username = user_data['login'] github_id = user_data['id'] @@ -112,6 +114,9 @@ def github_oauth_callback(): def github_oauth_attach(): token = exchange_github_code_for_token(request.args.get('code')) user_data = get_github_user(token) + if not user_data: + return render_page_template('githuberror.html', error_message='Could not load user data') + github_id = user_data['id'] user_obj = current_user.db_user() model.attach_federated_login(user_obj, 'github', github_id)