vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Change cloudfront storage to report non-cloudfront (i.e. S3) URLs for all requests missing IP information

Browse source 
This ensures the security scanner gets S3 URLs

Fixes https://jira.coreos.com/browse/QUAY-954
This commit is contained in:
Joseph Schorr 2018-07-05 16:16:20 +03:00
parent 100d7eae81
commit 7426f9e93a
2 changed files with 11 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

3
storage/test/test_cloudfront.py
View file

@ -64,5 +64,4 @@ def test_direct_download_no_ip(test_aws_ip, aws_ip_range_data, ipranges_populate
_TEST_BUCKET, _TEST_USER, _TEST_PASSWORD)
engine.put_content(_TEST_PATH, _TEST_CONTENT)
assert engine.exists(_TEST_PATH)
assert 'cloudfrontdomain' in engine.get_direct_download_url(_TEST_PATH)
assert 's3.amazonaws.com' in engine.get_direct_download_url(_TEST_PATH)