vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Have the V2 registry endpoints raise Unauthorized with the proper header when anonymous access is disabled

Browse source 
Before this change, we'd raise a generic 401, which was breaking containerd and cri-o.

Fixes https://jira.coreos.com/browse/QUAY-1332
This commit is contained in:
Joseph Schorr 2019-02-15 15:29:57 -05:00
parent c4f7b28dc6
commit 7690d5d495
4 changed files with 19 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
test/registry/registry_tests.py
View file

@ -350,8 +350,12 @@ def test_pull_publicrepo_no_anonymous_access(pusher, puller, basic_images, lives
with FeatureFlagValue('ANONYMOUS_ACCESS', False, registry_server_executor.on(liveserver)):
# Attempt again to pull the (now public) repo anonymously, which should fail since
# the feature flag for anonymous access is turned off.
options = ProtocolOptions()
options.attempt_pull_without_token = True
puller.pull(liveserver_session, 'public', 'newrepo', 'latest', basic_images,
expected_failure=Failures.ANONYMOUS_NOT_ALLOWED)
expected_failure=Failures.ANONYMOUS_NOT_ALLOWED,
options=options)
# Using a non-public user should now succeed.
puller.pull(liveserver_session, 'public', 'newrepo', 'latest', basic_images,