From 7736de24fe659ea7eaeeff18ed84eccd200b2472 Mon Sep 17 00:00:00 2001
From: Joseph Schorr <josephschorr@users.noreply.github.com>
Date: Thu, 20 Jul 2017 14:36:15 -0400
Subject: [PATCH] Add common_login test

---
 endpoints/common.py           |  2 +-
 endpoints/test/test_common.py | 25 +++++++++++++++++++++++++
 2 files changed, 26 insertions(+), 1 deletion(-)
 create mode 100644 endpoints/test/test_common.py

diff --git a/endpoints/common.py b/endpoints/common.py
index 79a06fa2f..457faaa52 100644
--- a/endpoints/common.py
+++ b/endpoints/common.py
@@ -48,7 +48,7 @@ def common_login(db_user, permanent_session=True):
 
     return True
   else:
-    logger.debug('User could not be logged in, inactive?.')
+    logger.debug('User could not be logged in, inactive?')
     return False
 
 
diff --git a/endpoints/test/test_common.py b/endpoints/test/test_common.py
new file mode 100644
index 000000000..7ede7c62c
--- /dev/null
+++ b/endpoints/test/test_common.py
@@ -0,0 +1,25 @@
+import pytest
+
+from data import model
+from endpoints.common import common_login
+
+from test.fixtures import *
+
+@pytest.mark.parametrize('username, expect_success', [
+  # Valid users.
+  ('devtable', True),
+  ('public', True),
+
+  # Org.
+  ('buynlarge', False),
+
+  # Robot.
+  ('devtable+dtrobot', False),
+
+  # Unverified user.
+  ('unverified', False),
+])
+def test_common_login(username, expect_success, app):
+  db_user = model.user.get_namespace_user(username)
+  with app.app_context():
+    assert common_login(db_user) == expect_success