vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Use ng-metadata as a Backport of Angular 2+ API (#2486)

Browse source 
* starting UtilService refactor

* pre find-replace angular.module('quay') => angular.module('QuayModule')

* successfully switched to ng-metadata for backported Angular2 API

* working with parent component reference in child

* fixing @Output to use EventEmitter

* fixed @Output events for custom git trigger

* more fixes

* refactored QuayPages module for backwards-compatibility

* reinitialized test.db

* use minified libraries

* replaced references for angular-ts-decorators

* fixed ng-show
This commit is contained in:
Alec Merdler 2017-04-05 14:14:08 -07:00 • committed by GitHub
parent 6352b3cac5
commit 7a352ddfbc
43 changed files with 642 additions and 551 deletions
Download patch file Download diff file Expand all files Collapse all files

10
static/js/directives/ui/context-path-select/context-path-select.component.spec.ts
View file

@ -17,23 +17,23 @@ describe("ContextPathSelectComponent", () => {
component.contexts = contexts;
});
describe("$onChanges", () => {
describe("ngOnChanges", () => {
it("sets valid context flag to true if current context is valid", () => {
component.$onChanges({});
component.ngOnChanges({});
expect(component.isValidContext).toBe(true);
});
it("sets valid context flag to false if current context is invalid", () => {
component.currentContext = "asdfdsf";
component.$onChanges({});
component.ngOnChanges({});
expect(component.isValidContext).toBe(false);
});
});
describe("setcontext", () => {
describe("setContext", () => {
var newContext: string;
beforeEach(() => {
@ -59,7 +59,7 @@ describe("ContextPathSelectComponent", () => {
});
});
describe("setCurrentcontext", () => {
describe("setSelectedContext", () => {
var context: string;
beforeEach(() => {

8
static/js/directives/ui/context-path-select/context-path-select.component.ts
View file

@ -1,14 +1,14 @@
import { Input, Component } from 'angular-ts-decorators';
import { Input, Component, OnChanges, SimpleChanges } from 'ng-metadata/core';
/**
* A component that allows the user to select the location of the Context in their source code repository.
*/
@Component({
selector: 'contextPathSelect',
selector: 'context-path-select',
templateUrl: '/static/js/directives/ui/context-path-select/context-path-select.component.html'
})
export class ContextPathSelectComponent implements ng.IComponentController {
export class ContextPathSelectComponent implements OnChanges {
// FIXME: Use one-way data binding
@Input('=') public currentContext: string;
@ -17,7 +17,7 @@ export class ContextPathSelectComponent implements ng.IComponentController {
private isUnknownContext: boolean = true;
private selectedContext: string | null = null;
public $onChanges(changes: ng.IOnChangesObject): void {
public ngOnChanges(changes: SimpleChanges): void {
this.isValidContext = this.checkContext(this.currentContext, this.contexts);
}