vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Remove unicode before sending it to path parser

Browse source 
Fixes https://sentry.io/coreos/backend-production/issues/175929456/
This commit is contained in:
Joseph Schorr 2017-02-21 14:25:26 -05:00
parent 3f1d394e14
commit 7cc7e54945
2 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
test/test_endpoints.py
View file

@ -134,6 +134,9 @@ class WebEndpointTestCase(EndpointTestCase):
def test_repo_view(self): def test_repo_view(self):
self.getResponse('web.repository', path='devtable/simple') self.getResponse('web.repository', path='devtable/simple')
def test_unicode_repo_view(self):
self.getResponse('web.repository', path='%E2%80%8Bcoreos/hyperkube%E2%80%8B')
def test_org_view(self): def test_org_view(self):
self.getResponse('web.org_view', path='buynlarge') self.getResponse('web.org_view', path='buynlarge')

4
util/names.py
View file

@ -1,6 +1,8 @@
import urllib import urllib
import re import re
import anunidecode # Don't listen to pylint's lies. This import is required for unidecode below.
from uuid import uuid4 from uuid import uuid4
REPOSITORY_NAME_REGEX = re.compile(r'^[\.a-zA-Z0-9_-]+$') REPOSITORY_NAME_REGEX = re.compile(r'^[\.a-zA-Z0-9_-]+$')
@ -23,6 +25,8 @@ def escape_tag(tag, default='latest'):
def parse_namespace_repository(repository, library_namespace, include_tag=False): def parse_namespace_repository(repository, library_namespace, include_tag=False):
repository = repository.encode('unidecode', 'ignore')
parts = repository.rstrip('/').split('/', 1) parts = repository.rstrip('/').split('/', 1)
if len(parts) < 2: if len(parts) < 2:
namespace = library_namespace namespace = library_namespace