From 7f4dd7d42f9fc8bd1687c938b879e09154d93a49 Mon Sep 17 00:00:00 2001
From: Jimmy Zelinskie <jimmy.zelinskie@coreos.com>
Date: Tue, 2 Jun 2015 15:43:55 -0400
Subject: [PATCH] triggers: backwards compatible schema for metadata

---
 buildman/component/buildcomponent.py                   | 10 +++++++++-
 static/directives/triggered-build-description.html     |  6 +++---
 static/js/directives/repo-view/repo-panel-builds.js    |  2 +-
 static/js/directives/ui/triggered-build-description.js |  2 +-
 static/js/services/trigger-service.js                  |  4 ++++
 5 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/buildman/component/buildcomponent.py b/buildman/component/buildcomponent.py
index 96afc6821..c4c8544d1 100644
--- a/buildman/component/buildcomponent.py
+++ b/buildman/component/buildcomponent.py
@@ -139,7 +139,7 @@ class BuildComponent(BaseComponent):
     if build_job.repo_build.trigger.private_key is not None:
       build_arguments['git'] = {
         'url': build_config['trigger_metadata'].get('git_url', ''),
-        'sha': build_config['trigger_metadata'].get('commit', ''),
+        'sha': BuildComponent._commit_sha(build_config),
         'private_key': build_job.repo_build.trigger.private_key,
       }
 
@@ -149,6 +149,14 @@ class BuildComponent(BaseComponent):
 
     self.call("io.quay.builder.build", **build_arguments).add_done_callback(self._build_complete)
 
+  @staticmethod
+  def _commit_sha(build_config):
+    """ Determines whether the metadata is using an old schema or not and returns the commit. """
+    commit_sha = build_config['trigger_metadata'].get('commit', '')
+    old_commit_sha = build_config['trigger_metadata'].get('commit_sha', '')
+    return commit_sha or old_commit_sha
+
+
   @staticmethod
   def _total_completion(statuses, total_images):
     """ Returns the current amount completion relative to the total completion of a build. """
diff --git a/static/directives/triggered-build-description.html b/static/directives/triggered-build-description.html
index 0ca5af364..1339df82b 100644
--- a/static/directives/triggered-build-description.html
+++ b/static/directives/triggered-build-description.html
@@ -21,14 +21,14 @@
     <div class="tbd-content" ng-switch-when="commitsha">
       Triggered by commit
       <span class="source-commit-link"
-            commit-sha="build.trigger_metadata.commit"></span>
+            commit-sha="TriggerService.getCommitSHA(build.trigger_metadata)"></span>
     </div>
 
     <!-- Full Commit Information -->
     <div class="tbd-content" ng-switch-when="fullcommit">
       <div class="commit-message">
         <span class="anchor" is-only-text="!TriggerService.getFullLinkTemplate(build, 'commit')"
-              target="_blank" href="{{ TriggerService.getFullLinkTemplate(build, 'commit').replace('{sha}', build.trigger_metadata.commit) }}">
+              target="_blank" href="{{ TriggerService.getFullLinkTemplate(build, 'commit').replace('{sha}', TriggerService.getCommitSHA(build.trigger_metadata)) }}">
           {{ build.trigger_metadata.commit_info.message }}
         </span>
       </div>
@@ -46,7 +46,7 @@
           </span>
         </span>
         <span class="source-commit-link"
-              commit-sha="build.trigger_metadata.commit"
+              commit-sha="TriggerService.getCommitSHA(build.trigger_metadata)"
               url-template="TriggerService.getFullLinkTemplate(build, 'commit')"></span>
         <span class="source-ref-link"
               ref="build.trigger_metadata.ref"
diff --git a/static/js/directives/repo-view/repo-panel-builds.js b/static/js/directives/repo-view/repo-panel-builds.js
index c98895a36..c6d24a6bf 100644
--- a/static/js/directives/repo-view/repo-panel-builds.js
+++ b/static/js/directives/repo-view/repo-panel-builds.js
@@ -45,7 +45,7 @@ angular.module('quay').directive('repoPanelBuilds', function () {
           var commit_sha = null;
 
           if (build_info.trigger_metadata) {
-            commit_sha = build_info.trigger_metadata.commit;
+            commit_sha = TriggerService.getCommitSHA(build_info.trigger_metadata);
           }
 
           return $.extend(build_info, {
diff --git a/static/js/directives/ui/triggered-build-description.js b/static/js/directives/ui/triggered-build-description.js
index 10aa87005..3b53a1a33 100644
--- a/static/js/directives/ui/triggered-build-description.js
+++ b/static/js/directives/ui/triggered-build-description.js
@@ -33,7 +33,7 @@ angular.module('quay').directive('triggeredBuildDescription', function () {
           return;
         }
 
-        if (build.trigger && build.trigger.build_source && triggerMetadata.commit) {
+        if (build.trigger && build.trigger.build_source && TriggerService.getCommitSHA(triggerMetadata)) {
           $scope.infoDisplay = 'commitsha';
           return;
         }
diff --git a/static/js/services/trigger-service.js b/static/js/services/trigger-service.js
index fd35b26e6..b5566aa18 100644
--- a/static/js/services/trigger-service.js
+++ b/static/js/services/trigger-service.js
@@ -252,6 +252,10 @@ angular.module('quay').factory('TriggerService', ['UtilService', '$sanitize', 'K
     return desc;
   };
 
+  triggerService.getCommitSHA = function(metadata) {
+    return metadata.commit || metadata.commit_sha;
+  };
+
   triggerService.getMetadata = function(name) {
     return triggerTypes[name];
   };