Write triggers are successfully installing on GitHub, noice!

endpoints/api.py

@@ -9,6 +9,7 @@ from flask.ext.login import current_user, logout_user
 from flask.ext.principal import identity_changed, AnonymousIdentity
 from functools import wraps
 from collections import defaultdict
+from urllib import quote
 
 from data import model
 from data.queue import dockerfile_build_queue
@@ -1363,6 +1364,11 @@ def get_build_trigger(namespace, repository, trigger_uuid):
   abort(403)  # Permission denied
 
 
+def _prepare_webhook_url(scheme, username, password, hostname, path):
+  auth_hostname = '%s:%s@%s' % (quote(username), quote(password), hostname)
+  return urlparse.urlunparse((scheme, auth_hostname, path, '', '', ''))
+
+
 @api.route('/repository/<path:repository>/trigger/<trigger_uuid>/activate',
            methods=['POST'])
 @api_login_required
@@ -1386,20 +1392,29 @@ def activate_build_trigger(namespace, repository, trigger_uuid):
     if user_permission.can():
       new_config_dict = request.get_json()
 
+      token_name = 'Build Trigger: %s' % trigger.service.name
+      token = model.create_delegate_token(namespace, repository, token_name,
+                                          'write')
+
       try:
         repository = '%s/%s' % (trigger.repository.namespace,
                                 trigger.repository.name)
-        webhook_url = url_for('webhooks.build_trigger_webhook',
-                              repository=repository, trigger_uuid=trigger.uuid,
-                              _external=True)
-        handler.activate(trigger.uuid, webhook_url, trigger.auth_token,
+        path = url_for('webhooks.build_trigger_webhook', repository=repository,
+                       trigger_uuid=trigger.uuid)
+        authed_url = _prepare_webhook_url(app.config['URL_SCHEME'], '$token',
+                                          token.code, app.config['URL_HOST'],
+                                          path)
+
+        handler.activate(trigger.uuid, authed_url, trigger.auth_token,
                          new_config_dict)
       except TriggerActivationException as e:
+        token.delete_instance()
         abort(400, message = e.msg)
         return
 
       # Save the updated config.
       trigger.config = json.dumps(new_config_dict)
+      trigger.write_token = token
       trigger.save()
 
       return jsonify(trigger_view(trigger))

endpoints/trigger.py

@@ -1,7 +1,7 @@
 import logging
 import io
 
-from github import Github
+from github import Github, UnknownObjectException, GithubException
 from tempfile import SpooledTemporaryFile
 
 from app import app
@@ -27,6 +27,9 @@ class InvalidServiceException(Exception):
 class TriggerActivationException(Exception):
   pass
 
+class ValidationRequestException(Exception):
+  pass
+
 
 class BuildTrigger(object):
   def __init__(self):
@@ -97,17 +100,20 @@ class GithubBuildTrigger(BuildTrigger):
 
     try:
       to_add_webhook = gh_client.get_repo(new_build_source)
+    except UnknownObjectException:
+      msg = 'Unable to find GitHub repository for source: %s'
+      raise TriggerActivationException(msg % new_build_source)
 
-      webhook_config = {
-        'url': standard_webhook_url,
-        'content_type': 'json',
-      }
+    webhook_config = {
+      'url': standard_webhook_url,
+      'content_type': 'json',
+    }
 
+    try:
       to_add_webhook.create_hook('web', webhook_config)
-
-
-    except Exception:
-      pass
+    except GithubException:
+      msg = 'Unable to create webhook on repository: %s'
+      raise TriggerActivationException(msg % new_build_source)
 
   def list_build_sources(self, auth_token):
     gh_client = self._get_client(auth_token)
@@ -142,6 +148,10 @@ class GithubBuildTrigger(BuildTrigger):
 
   def handle_trigger_request(self, request, auth_token, config):
     payload = request.get_json()
+
+    if 'zen' in payload:
+      raise ValidationRequestException()
+
     logger.debug('Payload %s', payload)
     ref = payload['ref']
     commit_id = payload['head_commit']['id'][0:7]

endpoints/webhooks.py

@@ -11,7 +11,7 @@ from util.invoice import renderInvoiceToHtml
 from util.email import send_invoice_email
 from util.names import parse_repository_name
 from util.http import abort
-from endpoints.trigger import BuildTrigger
+from endpoints.trigger import BuildTrigger, ValidationRequestException
 
 
 logger = logging.getLogger(__name__)
@@ -61,9 +61,13 @@ def build_trigger_webhook(namespace, repository, trigger_uuid):
     handler = BuildTrigger.get_trigger_for_service(trigger.service.name)
 
     logger.debug('Passing webhook request to handler %s', handler)
-    df_id, tag, name = handler.handle_trigger_request(request,
-                                                      trigger.auth_token,
-                                                      trigger.config)
+    try:
+      df_id, tag, name = handler.handle_trigger_request(request,
+                                                        trigger.auth_token,
+                                                        trigger.config)
+    except ValidationRequestException:
+      # This was just a validation request, don't need to build anything
+      return make_response('Okay')
 
     host = urlparse.urlparse(request.url).netloc
     full_tag = '%s/%s/%s:%s' % (host, trigger.repository.namespace,