Ensure that verbs cannot be performed on disabled namespaces or by disabled users

This commit is contained in:
Joseph Schorr 2018-06-19 17:32:17 -04:00
parent db7e5f7cfa
commit 892cc82b6a
4 changed files with 47 additions and 0 deletions

View file

@ -204,6 +204,10 @@ def _verify_repo_verb(_, namespace, repo_name, tag, verb, checker=None):
get_authenticated_user())
abort(405)
# Make sure the repo's namespace isn't disabled.
if not model.is_namespace_enabled(namespace):
abort(400)
# If there is a data checker, call it first.
if checker is not None:
if not checker(tag_image):

View file

@ -152,3 +152,8 @@ class VerbsDataInterface(object):
or None if none.
"""
pass
@abstractmethod
def is_namespace_enabled(self, namespace_name):
""" Returns whether the given namespace exists and is enabled. """
pass

View file

@ -141,6 +141,10 @@ class PreOCIModel(VerbsDataInterface):
v1_metadata=_docker_v1_metadata(namespace_name, repo_name, found),
internal_db_id=found.id,)
def is_namespace_enabled(self, namespace_name):
namespace = model.user.get_namespace_user(namespace_name)
return namespace is not None and namespace.enabled
pre_oci_model = PreOCIModel()