vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Always allow robot accounts to be selected by admins in trigger setup

Browse source 
Currently during trigger setup, if we don't know for sure that a robot account is necessary, we don't show the option to select one. This fails if the user has a Dockerfile in a branch or tag with a private base image *or* they *intend* to add a private base image once the trigger is setup. Following this change, we always show the option to select a robot account, even if it isn't determined to be strictly necessary.
This commit is contained in:
Joseph Schorr 2017-03-17 14:42:32 -04:00
parent f08e4921f2
commit 8bbe0e5e9b
3 changed files with 122 additions and 116 deletions
Download patch file Download diff file Expand all files Collapse all files

2
static/js/directives/ui/manage-trigger-githost/manage-trigger-githost.component.ts
View file

@ -129,7 +129,7 @@ export class ManageTriggerGithostComponent implements ng.IComponentController {
this.activateTrigger({'config': config, 'pull_robot': this.local.robotAccount});
};
if (this.local.robotAccount) {
if (this.local.robotAccount && this.local.triggerAnalysis.status == 'requiresrobot') {
if (this.local.robotAccount.can_read) {
activate();
} else {