Remove old search API and switch V1 search to use the new search system

endpoints/api/search.py

@@ -95,38 +95,6 @@ class EntitySearch(ApiResource):
     }
 
 
-@resource('/v1/find/repository')
-class FindRepositories(ApiResource):
-  """ Resource for finding repositories. """
-  @parse_args
-  @query_param('query', 'The prefix to use when querying for repositories.', type=str, default='')
-  @require_scope(scopes.READ_REPO)
-  @nickname('findRepos')
-  def get(self, args):
-    """ Get a list of repositories that match the specified prefix query. """
-    prefix = args['query']
-
-    def repo_view(repo):
-      return {
-        'namespace': repo.namespace_user.username,
-        'name': repo.name,
-        'description': repo.description
-      }
-
-    username = None
-    user = get_authenticated_user()
-    if user is not None:
-      username = user.username
-
-    matching = model.repository.get_matching_repositories(prefix, username)
-    return {
-      'repositories': [repo_view(repo) for repo in matching
-                       if (repo.visibility.name == 'public' or
-                           ReadRepositoryPermission(repo.namespace_user.username, repo.name).can())]
-    }
-
-
-
 def search_entity_view(username, entity, get_short_name=None):
   kind = 'user'
   avatar_data = avatar.get_data_for_user(entity)

endpoints/v1/index.py

@@ -296,16 +296,31 @@ def put_repository_auth(namespace, repository):
   abort(501, 'Not Implemented', issue='not-implemented')
 
 
+def conduct_repo_search(username, query, results):
+  """ Finds matching repositories. """
+  def can_read(repo):
+    if repo.is_public:
+      return True
+
+    return ReadRepositoryPermission(repo.namespace_user.username, repo.name).can()
+
+  only_public = username is None
+  matching_repos = model.repository.get_sorted_matching_repositories(query, only_public, can_read,
+                                                                     limit=5)
+
+  for repo in matching_repos:
+    results.append({
+      'name': repo.name,
+      'description': repo.description,
+      'is_public': repo.is_public,
+      'href': '/repository/' + repo.namespace_user.username + '/' + repo.name
+    })
+
+
 @v1_bp.route('/search', methods=['GET'])
 @process_auth
 @anon_protect
 def get_search():
-  def result_view(repo):
-    return {
-      "name": repo.namespace_user.username + '/' + repo.name,
-      "description": repo.description
-    }
-
   query = request.args.get('q')
 
   username = None
@@ -313,14 +328,8 @@ def get_search():
   if user is not None:
     username = user.username
 
-  if query:
-    matching = model.repository.get_matching_repositories(query, username)
-  else:
-    matching = []
-
-  results = [result_view(repo) for repo in matching
-             if (repo.visibility.name == 'public' or
-                 ReadRepositoryPermission(repo.namespace_user.username, repo.name).can())]
+  results = []
+  conduct_repo_search(username, query, results)
 
   data = {
     "query": query,