vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Add mix panel reporting to http error codes

Browse source
This commit is contained in:
Joseph Schorr 2014-01-24 20:29:25 -05:00
parent 0d84cfdf17
commit 8d074d8f3a
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
util/http.py
View file

@ -1,5 +1,6 @@
import logging import logging
from app import mixpanel
from flask import request, abort as flask_abort, make_response from flask import request, abort as flask_abort, make_response
from auth.auth import process_auth, extract_namespace_repo_from_session, get_authenticated_user, get_validated_token from auth.auth import process_auth, extract_namespace_repo_from_session, get_authenticated_user, get_validated_token
@ -15,16 +16,21 @@ DEFAULT_MESSAGE[409] = 'Conflict'
def abort(status_code, message=None, **kwargs): def abort(status_code, message=None, **kwargs):
message = str(message) % kwargs if message else DEFAULT_MESSAGE.get(status_code, '') message = str(message) % kwargs if message else DEFAULT_MESSAGE.get(status_code, '')
params = dict(request.view_args)
params.copy(kwargs)
# Add the user information. # Add the user information.
auth_user = get_authenticated_user() auth_user = get_authenticated_user()
auth_token = get_validated_token() auth_token = get_validated_token()
if auth_user: if auth_user:
mixpanel.track(auth_user.username, 'http_error', params)
message = '%s (user: %s)' % (message, auth_user.username) message = '%s (user: %s)' % (message, auth_user.username)
elif auth_token: elif auth_token:
mixpanel.track(auth_token.core, 'http_error', params)
message = '%s (token: %s)' % (message, auth_token.friendly_name or auth_token.code) message = '%s (token: %s)' % (message, auth_token.friendly_name or auth_token.code)
# Log the abort. # Log the abort.
logger.error('Error %s: %s. Arguments: %s' % (status_code, message, request.view_args)) logger.error('Error %s: %s. Arguments: %s' % (status_code, message, params))
# Report the abort to the user. # Report the abort to the user.
flask_abort(make_response(message, status_code, {})) flask_abort(make_response(message, status_code, {}))